src/trusted/service_runtime/arch/mips/tramp_mips.S - Issue 10978045: [MIPS] Use break instruction as NACL_HALT for MIPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/service_runtime/arch/mips/tramp_mips.S

Issue 10978045: [MIPS] Use break instruction as NACL_HALT for MIPS. (Closed)

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/trusted/service_runtime/arch/mips/tramp_mips.S

diff --git a/src/trusted/service_runtime/arch/mips/tramp_mips.S b/src/trusted/service_runtime/arch/mips/tramp_mips.S

index 9ac8ddf631b98a74b1b6c0020994246ab32523da..ac955226b370aa0c9b7953989eed22aa7677a03c 100644

--- a/src/trusted/service_runtime/arch/mips/tramp_mips.S

+++ b/src/trusted/service_runtime/arch/mips/tramp_mips.S

@@ -42,7 +42,7 @@ DEFINE_GLOBAL_HIDDEN_IDENTIFIER(NaCl_trampoline_seg_code):

jalr $t5, $t9

nop

- jr $0 /* NACL_HALT - at the start of the second block of the trampoline */

+ NACL_HALT

.set reorder

DEFINE_GLOBAL_HIDDEN_IDENTIFIER(NaCl_trampoline_seg_end):