src/trusted/service_runtime/arch/mips/sel_ldr_mips.h - Issue 10978045: [MIPS] Use break instruction as NACL_HALT for MIPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/service_runtime/arch/mips/sel_ldr_mips.h

Issue 10978045: [MIPS] Use break instruction as NACL_HALT for MIPS. (Closed)

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/trusted/service_runtime/arch/mips/sel_ldr_mips.h

diff --git a/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h b/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h

index 9161f0c02e871c6dd059f2c0037b69ce3474b0c2..d54824d9f134fb1e5e4d18a83ad3d802c771be8f 100644

--- a/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h

+++ b/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h

@@ -21,7 +21,7 @@

#define NACL_THREAD_MAX 8192

#define NACL_NOOP_OPCODE 0x00000000 /* nop */

-#define NACL_HALT_OPCODE 0x00000008 /* jr $0 */

+#define NACL_HALT_OPCODE 0x0000000D /* break */

#define NACL_HALT_LEN 4 /* length of halt instruction */

#define NACL_HALT_WORD NACL_HALT_OPCODE