Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 10974012: Move base Java utils to base/test/android/javatests. (Closed)

Created:
8 years, 3 months ago by nyquist
Modified:
8 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, bulach
Visibility:
Public.

Description

Move base Java utils to base/test/android/javatests. gyp targets should not depend on tests from other packages, but instead be able to depend on their test utils. The target including the base utilities is called base_java_test_support and contains files from base/test/android/javatests. base_java_test_support was also the name of the wrongly named target for building base/android/javatests, but since only contained util-classes, no new target has been created for tests of base/android/java. BUG=151561, 150773 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158422

Patch Set 1 #

Total comments: 2

Patch Set 2 : moved util packaged to test subpackage. addded OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -271 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewLoadUrlTest.java View 1 1 chunk +1 line, -7 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 1 1 chunk +4 lines, -9 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewAsynchronousFindApisTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewMixedFindApisTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java View 1 1 chunk +1 line, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewSynchronousFindApisTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
D base/android/javatests/src/org/chromium/base/test/DisabledTest.java View 1 chunk +0 lines, -21 lines 0 comments Download
D base/android/javatests/src/org/chromium/base/test/Feature.java View 1 chunk +0 lines, -29 lines 0 comments Download
D base/android/javatests/src/org/chromium/base/test/InstrumentationUtils.java View 1 chunk +0 lines, -32 lines 0 comments Download
D base/android/javatests/src/org/chromium/base/test/ScalableTimeout.java View 1 chunk +0 lines, -28 lines 0 comments Download
D base/android/javatests/src/org/chromium/base/test/TestFileUtil.java View 1 chunk +0 lines, -77 lines 0 comments Download
D base/android/javatests/src/org/chromium/base/test/UrlUtils.java View 1 chunk +0 lines, -23 lines 0 comments Download
M base/base.gyp View 1 chunk +1 line, -1 line 0 comments Download
A + base/test/android/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + base/test/android/javatests/src/org/chromium/base/test/util/DisabledTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + base/test/android/javatests/src/org/chromium/base/test/util/Feature.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + base/test/android/javatests/src/org/chromium/base/test/util/InstrumentationUtils.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + base/test/android/javatests/src/org/chromium/base/test/util/ScalableTimeout.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + base/test/android/javatests/src/org/chromium/base/test/util/TestFileUtil.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + base/test/android/javatests/src/org/chromium/base/test/util/UrlUtils.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/DummyIntegrationTest.java View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellUrlTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java View 1 1 chunk +1 line, -6 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java View 1 1 chunk +2 lines, -4 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/util/HistoryUtils.java View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/javatests/src/org/chromium/content_shell/ContentShellUrlTest.java View 1 1 chunk +1 line, -3 lines 0 comments Download
M net/android/javatests/src/org/chromium/net/AndroidProxySelectorTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M net/android/javatests/src/org/chromium/net/NetErrorsTest.java View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
nyquist
PTAL
8 years, 3 months ago (2012-09-24 18:34:59 UTC) #1
Yaron
lgtm Please also add a base/test/android/OWNERS file with ppl from base/android/OWNERS https://codereview.chromium.org/10974012/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/WebViewSynchronousFindApisTest.java File android_webview/javatests/src/org/chromium/android_webview/test/WebViewSynchronousFindApisTest.java (right): ...
8 years, 3 months ago (2012-09-24 18:44:28 UTC) #2
klundberg
lgtm https://codereview.chromium.org/10974012/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/WebViewSynchronousFindApisTest.java File android_webview/javatests/src/org/chromium/android_webview/test/WebViewSynchronousFindApisTest.java (right): https://codereview.chromium.org/10974012/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/WebViewSynchronousFindApisTest.java#newcode9 android_webview/javatests/src/org/chromium/android_webview/test/WebViewSynchronousFindApisTest.java:9: import org.chromium.base.util.Feature; On 2012/09/24 18:44:28, Yaron wrote: > ...
8 years, 3 months ago (2012-09-24 18:52:30 UTC) #3
nyquist
8 years, 3 months ago (2012-09-24 19:03:50 UTC) #4
nyquist
mark: could you please take a look at base/?
8 years, 3 months ago (2012-09-24 19:09:04 UTC) #5
Mark Mentovai
Just to appease the commit queue? LGTM for purposes of moving things between OWNed directories ...
8 years, 3 months ago (2012-09-24 19:16:02 UTC) #6
joth
lgtm
8 years, 3 months ago (2012-09-24 19:51:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/10974012/5001
8 years, 3 months ago (2012-09-24 19:52:09 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years, 3 months ago (2012-09-24 22:14:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/10974012/5001
8 years, 3 months ago (2012-09-24 22:17:11 UTC) #10
commit-bot: I haz the power
8 years, 3 months ago (2012-09-24 22:22:31 UTC) #11
Change committed as 158422

Powered by Google App Engine
This is Rietveld 408576698