Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 10974008: Aura: Keep scheduling in line with other platforms. (Closed)

Created:
8 years, 2 months ago by jonathan.backer
Modified:
8 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Aura: Keep scheduling in line with other platforms. OSX and Vista+ only deschedule the image transport surface if there is a draw. This allows a greater amount of asynchronicity while waiting for a present (e.g. texture uploads). This small change does the same for Aura. BUG=none TEST=by hand Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159029

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address reviewer comments. #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M content/common/gpu/texture_image_transport_surface.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.cc View 1 2 6 chunks +30 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jonathan.backer
8 years, 2 months ago (2012-09-24 13:28:20 UTC) #1
piman
lgtm https://chromiumcodereview.appspot.com/10974008/diff/1/content/common/gpu/texture_image_transport_surface.cc File content/common/gpu/texture_image_transport_surface.cc (right): https://chromiumcodereview.appspot.com/10974008/diff/1/content/common/gpu/texture_image_transport_surface.cc#newcode126 content/common/gpu/texture_image_transport_surface.cc:126: if (did_unschedule_) nit: How can this be called ...
8 years, 2 months ago (2012-09-24 16:29:47 UTC) #2
jonathan.backer
https://chromiumcodereview.appspot.com/10974008/diff/1/content/common/gpu/texture_image_transport_surface.cc File content/common/gpu/texture_image_transport_surface.cc (right): https://chromiumcodereview.appspot.com/10974008/diff/1/content/common/gpu/texture_image_transport_surface.cc#newcode126 content/common/gpu/texture_image_transport_surface.cc:126: if (did_unschedule_) On 2012/09/24 16:29:48, piman wrote: > nit: ...
8 years, 2 months ago (2012-09-24 21:08:18 UTC) #3
piman
lgtm
8 years, 2 months ago (2012-09-24 21:12:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/10974008/9002
8 years, 2 months ago (2012-09-26 19:45:08 UTC) #5
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 2 months ago (2012-09-26 22:55:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/10974008/9002
8 years, 2 months ago (2012-09-27 02:15:08 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-09-27 03:55:06 UTC) #8
Retried try job too often for step(s) browser_tests

Powered by Google App Engine
This is Rietveld 408576698