Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 10968064: Move the NOTIFICATION_APP_TERMINATING notification from content to chrome, since it's fired by chro… (Closed)

Created:
8 years, 3 months ago by jam
Modified:
8 years, 2 months ago
Reviewers:
yurys
CC:
chromium-reviews, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, jeremya+watch_chromium.org, dcheng, ajwong+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, cbentzel+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, Avi (use Gerrit), jennb, creis+watch_chromium.org, jianli, gavinp+prer_chromium.org, oshima+watch_chromium.org, mihaip-chromium-reviews_chromium.org, Dmitry Titov, Aaron Boodman, dominich+watch_chromium.org, davemoore+watch_chromium.org, mmenke
Visibility:
Public.

Description

Move the NOTIFICATION_APP_TERMINATING notification from content to chrome, since it's fired by chrome. I removed the code watching it in the workers devtools code. It's not clear if this code is needed or not, so removing it for now. If we get crash reports or memory leaks on bots, then we'll have a repro that we can use to fix this. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158566

Patch Set 1 #

Patch Set 2 : cros compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -61 lines) Patch
M chrome/browser/background/background_mode_manager.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/power/power_api_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/browser_state_monitor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/power_button_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_ui_manager_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_window.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/uma_browsing_activity_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/debugger/worker_devtools_manager.cc View 4 chunks +1 line, -26 lines 0 comments Download
M content/public/browser/notification_types.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 3 months ago (2012-09-24 17:04:49 UTC) #1
yurys
8 years, 3 months ago (2012-09-25 04:15:55 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698