Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 10966011: Supported sourceURL comments for scripts having a name. (Closed)

Created:
8 years, 3 months ago by vsevik
Modified:
8 years, 3 months ago
Reviewers:
yurys
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Supported sourceURL comments for scripts having a name. sourceURL comment is now preferred script name for all scripts except for those with non zero start position (e.g. inline scripts in HTML). BUG=v8:2342 Committed: https://code.google.com/p/v8/source/detail?r=12576

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comments addressed: changed method comment and added a test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -5 lines) Patch
M src/messages.js View 1 2 chunks +6 lines, -5 lines 0 comments Download
M test/cctest/cctest.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
Please add a test for this. https://codereview.chromium.org/10966011/diff/1/src/messages.js File src/messages.js (right): https://codereview.chromium.org/10966011/diff/1/src/messages.js#newcode535 src/messages.js:535: * Returns contents ...
8 years, 3 months ago (2012-09-20 15:22:29 UTC) #1
vsevik
Please take another look
8 years, 3 months ago (2012-09-20 17:13:51 UTC) #2
yurys
8 years, 3 months ago (2012-09-21 07:19:09 UTC) #3
LGTM, you may also want to add a test for call stack returned by new Error.stack

Powered by Google App Engine
This is Rietveld 408576698