Remove 'shell=True' in Popen and directly execute testserver.py

build/android/pylib/chrome_test_server_spawner.py

Index: build/android/pylib/chrome_test_server_spawner.py
diff --git a/build/android/pylib/chrome_test_server_spawner.py b/build/android/pylib/chrome_test_server_spawner.py
index 1766a7731a644a6d2fe3fc6d595944085ae23491..30de65f7a6e393162b58dc17be7b61cd8dc9cbed 100644
--- a/build/android/pylib/chrome_test_server_spawner.py
+++ b/build/android/pylib/chrome_test_server_spawner.py
@@ -13,6 +13,7 @@ import json
 import logging
 import os
 import select
+import shlex
 import struct
 import subprocess
 import threading
@@ -212,7 +213,8 @@ class TestServerThread(threading.Thread):
                      'testserver.py'),
         ' '.join(self.command_line))
     logging.info(command)
-    self.process = subprocess.Popen(command, shell=True)
+    args = shlex.split(command)

[Isaac (away), 2012/09/24 07:30:46]

Thanks!  We might be able to avoid shlex too, if command_line list has only one
argument per entry.  Do you think the following would work?

command = [os.path.join(...., 'testserver.py')] + self.command_line
logging.info('running: %s', command)
self.process = subprocess.Popen(command)

+    self.process = subprocess.Popen(args)
     if self.process:
       if self.pipe_out:
         self.is_ready = self._WaitToStartAndGetPortFromTestServer()