Remove 'shell=True' in Popen and directly execute testserver.py

build/android/pylib/chrome_test_server_spawner.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A "Test Server Spawner" that handles killing/stopping per-test test servers.
 
 It's used to accept requests from the device to spawn and kill instances of the
 chrome test server on the host.
 """
 
 import BaseHTTPServer
 import json
 import logging
 import os
 import select
+import shlex
 import struct
 import subprocess
 import threading
 import time
 import urlparse
 
 import constants
 from forwarder import Forwarder
 import ports
 
@@ skipping 179 matching lines @@
 
   def run(self):
     logging.info('Start running the thread!')
     self.wait_event.clear()
     self._GenerateCommandLineArguments()
     command = '%s %s' % (
         os.path.join(constants.CHROME_DIR, 'net', 'tools', 'testserver',
                      'testserver.py'),
         ' '.join(self.command_line))
     logging.info(command)
-    self.process = subprocess.Popen(command, shell=True)
+    args = shlex.split(command)

[Isaac (away), 2012/09/24 07:30:46]

Thanks!  We might be able to avoid shlex too, if command_line list has only one
argument per entry.  Do you think the following would work?

command = [os.path.join(...., 'testserver.py')] + self.command_line
logging.info('running: %s', command)
self.process = subprocess.Popen(command)

+    self.process = subprocess.Popen(args)
     if self.process:
       if self.pipe_out:
         self.is_ready = self._WaitToStartAndGetPortFromTestServer()
       else:
         self.is_ready = _CheckPortStatus(self.host_port, True)
     if self.is_ready:
       self._test_server_forwarder = Forwarder(
           self.adb, [(0, self.host_port)], self.tool, '127.0.0.1',
           self.build_type)
       # Check whether the forwarder is ready on the device.
@@ skipping 169 matching lines @@
   def Start(self):
     listener_thread = threading.Thread(target=self._Listen)
     listener_thread.setDaemon(True)
     listener_thread.start()
     time.sleep(1)
 
   def Stop(self):
     if self.server.test_server_instance:
       self.server.test_server_instance.Stop()
     self.server.shutdown()