Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6087)

Unified Diff: chrome/browser/resources/about_version.html

Issue 10957027: Add Application version and OS info in android about version page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/about_version.html
diff --git a/chrome/browser/resources/about_version.html b/chrome/browser/resources/about_version.html
index 45ab5b2b8cba949c3c837c65f61c25b153c5fffe..aa48e5de0e9bedc9fb91aff16253fc32a5079076 100644
--- a/chrome/browser/resources/about_version.html
+++ b/chrome/browser/resources/about_version.html
@@ -33,9 +33,16 @@ about:version template page
<div id="copyright" i18n-content="copyright"></div>
</div>
<table id="inner" cellpadding="0" cellspacing="0" border="0">
+<if expr="pp_ifdef('android')">
Evan Stade 2012/09/21 12:43:47 I don't get why you're making these changes. It lo
nilesh 2012/09/21 17:08:28 Google Chrome: 22.0.1229.64 (Official Build 157476
+ <tr><td class="label" valign="top" id="application" i18n-content="application"></td>
Evan Stade 2012/09/21 12:43:47 don't go over 80 characters (ignore that this file
+ <td class="version" id="app_version"><span i18n-content="app_label"></span> <span i18n-content="app_version"></span></td>
+ </tr>
+</if>
+<if expr="not pp_ifdef('android')">
<tr><td class="label" valign="top" id="name" i18n-content="name"></td>
<td class="version" id="version"><span i18n-content="version"></span> (<span i18n-content="official"></span> <span i18n-content="cl"></span>) <span i18n-content="version_modifier"></span></td>
</tr>
+</if>
<if expr="not pp_ifdef('chromeos')">
<tr><td class="label" valign="top" i18n-content="os_name"></td>
<td class="version" id="os_type"><span i18n-content="os_type"></span> <span i18n-content="os_version"></span></td>
« no previous file with comments | « no previous file | chrome/browser/ui/android/android_about_app_info.h » ('j') | chrome/browser/ui/android/android_about_app_info.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698