Add Application version and OS info in android about version page.

Add method to get os info for android chrome:://version page.


BUG=140042
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158162

[nilesh, 2012-09-20 23:53:58]

AndroidAboutAppInfo is also used to show os info in the java app (in settings).

Yaron: chrome/browser/ui/android
Evan: Everything else.

[gone, 2012-09-20 23:54:53]

On 2012/09/20 23:47:50, nileshagrawal1 wrote:

LGTM

[Yaron, 2012-09-21 00:51:57]

lgtm

When you cherry-pick, please promote the frozen file in chrome/browser/resources
to a higher level :)

http://codereview.chromium.org/10957027/diff/1/chrome/browser/ui/android/andr...
File chrome/browser/ui/android/android_about_app_info.h (right):

http://codereview.chromium.org/10957027/diff/1/chrome/browser/ui/android/andr...
chrome/browser/ui/android/android_about_app_info.h:10: class AndroidAboutAppInfo
{
I think this should use a namespace:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Nonmem...

[Evan Stade, 2012-09-21 12:43:47]

https://chromiumcodereview.appspot.com/10957027/diff/1/chrome/browser/resourc...
File chrome/browser/resources/about_version.html (right):

https://chromiumcodereview.appspot.com/10957027/diff/1/chrome/browser/resourc...
chrome/browser/resources/about_version.html:36: <if expr="pp_ifdef('android')">
I don't get why you're making these changes. It looks like the markup is staying
exactly the same, but the text content is changing. Why not just change the
value of the strings on android?

https://chromiumcodereview.appspot.com/10957027/diff/1/chrome/browser/resourc...
chrome/browser/resources/about_version.html:37: <tr><td class="label"
valign="top" id="application" i18n-content="application"></td>
don't go over 80 characters (ignore that this file is a mess)

[Evan Stade, 2012-09-21 12:44:02]

forgot this part...

+stevet

you'll want to coordinate with http://codereview.chromium.org/10916182/

[SteveT, 2012-09-21 12:53:47]

So I was tasked with refactoring about:version out of about_ui... Shall we race,
or are you guys OK with merging if my patch goes in first? :)  I hope that
that'll happen sometime today.

[nilesh, 2012-09-21 16:53:37]

Thanks for the heads up.
I will wait for Steve's CL to land and remove about_ui.cc and about_version.html
form this CL.

[SteveT, 2012-09-21 17:06:25]

Nilesh - thanks for the patience! I'll try to get this in ASAP. Just waiting on
OWNERS review at this point.

[nilesh, 2012-09-21 17:08:28]

http://codereview.chromium.org/10957027/diff/1/chrome/browser/resources/about...
File chrome/browser/resources/about_version.html (right):

http://codereview.chromium.org/10957027/diff/1/chrome/browser/resources/about...
chrome/browser/resources/about_version.html:36: <if expr="pp_ifdef('android')">
Google Chrome: 22.0.1229.64 (Official Build 157476) beta

For android this is
Application: Chrome Beta 18.0.102530

I can check with PMs if we are flexible around it, but it is difficult to get to
the current string with just changing the values.

[nilesh, 2012-09-21 18:16:30]

Scott: For chrome/OWNERS

[nilesh, 2012-09-21 22:08:46]

Scott, I need chrome/OWNERS approval for this.

[sky, 2012-09-21 23:20:25]

http://codereview.chromium.org/10957027/diff/13001/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (right):

http://codereview.chromium.org/10957027/diff/13001/chrome/chrome_browser_ui.g...
chrome/chrome_browser_ui.gypi:2309:
'browser/ui/android/android_about_app_info.cc',
Move these to 'sources' above.

[nilesh, 2012-09-21 23:25:16]

http://codereview.chromium.org/10957027/diff/13001/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (right):

http://codereview.chromium.org/10957027/diff/13001/chrome/chrome_browser_ui.g...
chrome/chrome_browser_ui.gypi:2309:
'browser/ui/android/android_about_app_info.cc',
On 2012/09/21 23:20:26, sky wrote:
> Move these to 'sources' above.

In that case, I need to rename this to about_app_info_android.cc, right? (for
the gyp exclusion rules to work)?

[nilesh, 2012-09-21 23:26:08]

Sorry got it, the /android/ rule will take care of it.

[nilesh, 2012-09-21 23:34:43]

PTAL. Updated description too.

http://codereview.chromium.org/10957027/diff/13001/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (right):

http://codereview.chromium.org/10957027/diff/13001/chrome/chrome_browser_ui.g...
chrome/chrome_browser_ui.gypi:2309:
'browser/ui/android/android_about_app_info.cc',
Done.

[sky, 2012-09-21 23:37:08]

LGTM

[commit-bot: I haz the power, 2012-09-21 23:47:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10957027/12003

[commit-bot: I haz the power, 2012-09-22 00:09:01]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-22 00:53:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10957027/6006

[commit-bot: I haz the power, 2012-09-22 02:57:44]

Change committed as 158162