chrome/browser/resources/about_version.html - Issue 10957027: Add Application version and OS info in android about version page.

Side by Side Diff: chrome/browser/resources/about_version.html

Issue 10957027: Add Application version and OS info in android about version page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2	2

3 <!--	3 <!--

4 about:version template page	4 about:version template page

5 -->	5 -->

6	6

7 <html id="t" i18n-values="dir:textdirection;">	7 <html id="t" i18n-values="dir:textdirection;">

8 <head>	8 <head>

9 <title i18n-content="title"></title>	9 <title i18n-content="title"></title>

10 <if expr="pp_ifdef('android')">	10 <if expr="pp_ifdef('android')">

(...skipping 15 matching lines...) Expand all Loading...
26 <if expr="pp_ifdef('enable_themes')">	26 <if expr="pp_ifdef('enable_themes')">

27 <img src="chrome://theme/IDR_PRODUCT_LOGO">	27 <img src="chrome://theme/IDR_PRODUCT_LOGO">

28 </if>	28 </if>

29 <if expr="not pp_ifdef('enable_themes')">	29 <if expr="not pp_ifdef('enable_themes')">

30 <img src="../../app/theme/default_100_percent/%DISTRIBUTION%/product_log o.png">	30 <img src="../../app/theme/default_100_percent/%DISTRIBUTION%/product_log o.png">

31 </if>	31 </if>

32 <div id="company" i18n-content="company"></div>	32 <div id="company" i18n-content="company"></div>

33 <div id="copyright" i18n-content="copyright"></div>	33 <div id="copyright" i18n-content="copyright"></div>

34 </div>	34 </div>

35 <table id="inner" cellpadding="0" cellspacing="0" border="0">	35 <table id="inner" cellpadding="0" cellspacing="0" border="0">

	36 <if expr="pp_ifdef('android')">
	Evan Stade 2012/09/21 12:43:47 I don't get why you're making these changes. It lo I don't get why you're making these changes. It looks like the markup is staying exactly the same, but the text content is changing. Why not just change the value of the strings on android? nilesh 2012/09/21 17:08:28 Google Chrome: 22.0.1229.64 (Official Build 157476 Google Chrome: 22.0.1229.64 (Official Build 157476) beta For android this is Application: Chrome Beta 18.0.102530 I can check with PMs if we are flexible around it, but it is difficult to get to the current string with just changing the values.
	37 <tr><td class="label" valign="top" id="application" i18n-content="applic ation"></td>
	Evan Stade 2012/09/21 12:43:47 don't go over 80 characters (ignore that this file don't go over 80 characters (ignore that this file is a mess)
	38 <td class="version" id="app_version"><span i18n-content="app_label"></ span> <span i18n-content="app_version"></span></td>

	39 </tr>

	40 </if>

	41 <if expr="not pp_ifdef('android')">

36 <tr><td class="label" valign="top" id="name" i18n-content="name"></td>	42 <tr><td class="label" valign="top" id="name" i18n-content="name"></td>

37 <td class="version" id="version"><span i18n-content="version"></span> (<span i18n-content="official"></span> <span i18n-content="cl"></span>) <span i1 8n-content="version_modifier"></span></td>	43 <td class="version" id="version"><span i18n-content="version"></span> (<span i18n-content="official"></span> <span i18n-content="cl"></span>) <span i1 8n-content="version_modifier"></span></td>

38 </tr>	44 </tr>

	45 </if>

39 <if expr="not pp_ifdef('chromeos')">	46 <if expr="not pp_ifdef('chromeos')">

40 <tr><td class="label" valign="top" i18n-content="os_name"></td>	47 <tr><td class="label" valign="top" i18n-content="os_name"></td>

41 <td class="version" id="os_type"><span i18n-content="os_type"></span> <span i18n-content="os_version"></span></td>	48 <td class="version" id="os_type"><span i18n-content="os_type"></span> <span i18n-content="os_version"></span></td>

42 </if>	49 </if>

43 <if expr="pp_ifdef('chromeos')">	50 <if expr="pp_ifdef('chromeos')">

44 <tr><td class="label" valign="top" i18n-content="platform"></td>	51 <tr><td class="label" valign="top" i18n-content="platform"></td>

45 <td class="version" id="os_type"><span i18n-content="os_version"></spa n></td>	52 <td class="version" id="os_type"><span i18n-content="os_version"></spa n></td>

46 </if>	53 </if>

47 </tr>	54 </tr>

48 <tr><td class="label" valign="top">WebKit</td>	55 <tr><td class="label" valign="top">WebKit</td>

(...skipping 24 matching lines...) Expand all Loading...
73 <td class="version" id="variations-list"></td>	80 <td class="version" id="variations-list"></td>

74 </tr>	81 </tr>

75 </table>	82 </table>

76 </div>	83 </div>

77 <script src="chrome://resources/js/i18n_template.js"></script>	84 <script src="chrome://resources/js/i18n_template.js"></script>

78 <script src="chrome://resources/js/i18n_process.js"></script>	85 <script src="chrome://resources/js/i18n_process.js"></script>

79 <script src="chrome://resources/js/jstemplate_compiled.js"></script>	86 <script src="chrome://resources/js/jstemplate_compiled.js"></script>

80 </body>	87 </body>

81	88

82 </html>	89 </html>

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/ui/android/android_about_app_info.h » ('j') | chrome/browser/ui/android/android_about_app_info.h » ('J')