Issue 10957: Add superficial unit test for PrintJob. That's a start.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10957: Add superficial unit test for PrintJob. That's a start. (Closed)

Created:
12 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add superficial unit test for PrintJob. That's a start. Add more DCHECKs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5607

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+142 lines, -5 lines)			Patch
M	base/thread.cc	View	1 chunk	+0 lines, -3 lines	2 comments	Download
M	chrome/browser/printing/print_job.h	View	4 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/printing/print_job.cc	View	3 chunks	+11 lines, -1 line	0 comments	Download
A	chrome/browser/printing/print_job_unittest.cc	View	1 chunk	+117 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/unit/unit_tests.scons	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/unit/unittests.vcproj	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/10957/diff/1/5 File base/thread.cc (left): http://codereview.chromium.org/10957/diff/1/5#oldcode135 Line 135: // The thread can't receive messages anymore. It's ...

12 years, 1 month ago (2008-11-14 22:05:08 UTC) #2

M-A Ruel

http://codereview.chromium.org/10957/diff/1/5 File base/thread.cc (left): http://codereview.chromium.org/10957/diff/1/5#oldcode135 Line 135: // The thread can't receive messages anymore. On ...

12 years, 1 month ago (2008-11-15 02:26:01 UTC) #3

LGTM

Expand Messages | Collapse Messages