Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1605)

Unified Diff: base/thread.cc

Issue 10957: Add superficial unit test for PrintJob. That's a start. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/printing/print_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/thread.cc
===================================================================
--- base/thread.cc (revision 5486)
+++ base/thread.cc (working copy)
@@ -131,9 +131,6 @@
DCHECK(message_loop_);
message_loop_->PostTask(FROM_HERE, new ThreadQuitTask());
-
- // The thread can't receive messages anymore.
brettw 2008/11/14 22:05:08 It's not clear why you made this change.
M-A Ruel 2008/11/15 02:26:01 It's because it's doing this from the wrong thread
- message_loop_ = NULL;
}
void Thread::ThreadMain() {
« no previous file with comments | « no previous file | chrome/browser/printing/print_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698