Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: ppapi/generators/idl_gen_wrapper.py

Issue 10950042: PNaCl: Build a PPAPI shims library for all architectures (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/native_client/src/untrusted/pnacl_irt_shim/nacl.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/generators/idl_gen_wrapper.py
diff --git a/ppapi/generators/idl_gen_wrapper.py b/ppapi/generators/idl_gen_wrapper.py
index 36ed8b799537c54f6950041cedd9096609704885..e0bcf1fe6af8c26ec2eea02ab1ef0e16e5e2ebd8 100644
--- a/ppapi/generators/idl_gen_wrapper.py
+++ b/ppapi/generators/idl_gen_wrapper.py
@@ -430,6 +430,9 @@ const void *__%(wrapper_prefix)s_PPPGetInterface(const char *name) {
# Generate the includes.
self.GenerateIncludes(iface_releases, out)
+ out.Write('\n/* The PNaCl PPAPI shims are only needed on x86-64. */\n')
jvoung (off chromium) 2012/09/20 01:06:36 Hmm idl_gen_wrapper was actually meant to be for a
Mark Seaborn 2012/09/20 03:56:24 OK, I've split it into two parts.
jvoung (off chromium) 2012/09/20 15:13:48 Well there was an email thread about using somethi
+ out.Write('#if defined(__x86_64__)\n\n')
+
# Write out static helper functions (mystrcmp).
self.GenerateHelperFunctions(out)
@@ -449,5 +452,7 @@ const void *__%(wrapper_prefix)s_PPPGetInterface(const char *name) {
# Write out the IDL-invariant functions.
self.GenerateFixedFunctions(out)
+
+ out.Write('\n#endif\n')
out.Close()
return 0
« no previous file with comments | « no previous file | ppapi/native_client/src/untrusted/pnacl_irt_shim/nacl.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698