PNaCl: Build a PPAPI shims library for all architectures

ppapi/generators/idl_gen_wrapper.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Base class for generating wrapper functions for PPAPI methods.
 """
 
 from datetime import datetime
 import os
 import sys
@@ skipping 412 matching lines @@
     InfoOut.Log("Generating %s for %s" % (out_filename, self.wrapper_prefix))
 
     out = IDLOutFile(out_filename)
 
     # Get a list of all the interfaces along with metadata.
     iface_releases = self.DetermineInterfaces(ast, releases)
 
     # Generate the includes.
     self.GenerateIncludes(iface_releases, out)
 
+    out.Write('\n/* The PNaCl PPAPI shims are only needed on x86-64. */\n')

[jvoung (off chromium), 2012/09/20 01:06:36]

Hmm idl_gen_wrapper was actually meant to be for any kind of PPB/PPP wrapping
(e.g., if you want to instrument the calls), though nobody is really using it.  
idl_gen_pnacl specializes it for pnacl.

[Mark Seaborn, 2012/09/20 03:56:24]

OK, I've split it into two parts.
Yeah, I noticed. :-)  It did seem to be premature generalisation.

[jvoung (off chromium), 2012/09/20 15:13:48]

Well there was an email thread about using something like this to check test
coverage of the interfaces at the time I wrote it, but yeah it might not be the
right abstractions anyway.  Thanks for keeping the split.

+    out.Write('#if defined(__x86_64__)\n\n')
+
     # Write out static helper functions (mystrcmp).
     self.GenerateHelperFunctions(out)
 
     # Declare list of WrapperInfo before actual wrapper methods, since
     # they reference each other.
     self.DeclareWrapperInfos(iface_releases, out)
 
     # Generate wrapper functions for each wrapped method in the interfaces.
     result = self.GenerateWrapperForMethods(iface_releases)
     out.Write(result)
 
     # Collect all the wrapper functions into interface structs.
     self.GenerateWrapperInterfaces(iface_releases, out)
 
     # Generate a table of the wrapped interface structs that can be looked up.
     self.GenerateWrapperInfoAndCollection(iface_releases, out)
 
     # Write out the IDL-invariant functions.
     self.GenerateFixedFunctions(out)
+
+    out.Write('\n#endif\n')
     out.Close()
     return 0