Add native-side unit test for Android NetworkChangeNotifier

net/android/network_change_notifier_android.h

Index: net/android/network_change_notifier_android.h
diff --git a/net/android/network_change_notifier_android.h b/net/android/network_change_notifier_android.h
index 3c71dc5995bb31fdfacf88b46fc8e37ce2cb8106..79a2291ef7351973c9f339c32439b11ef08b9580 100644
--- a/net/android/network_change_notifier_android.h
+++ b/net/android/network_change_notifier_android.h
@@ -18,13 +18,13 @@ class NetworkChangeNotifier : public net::NetworkChangeNotifier {
   NetworkChangeNotifier();
   virtual ~NetworkChangeNotifier();
 
-  void NotifyObservers(JNIEnv* env, jobject obj);
+  void NotifyObserversOfConnectionTypeChange(JNIEnv* env, jobject obj);
+
+  void ForceConnectivityState(bool state);

[szym, 2012/09/14 19:07:29]

What is this for? If this is for tests only, at least add a comment, but
preferably hide it in the private section and friend the test suite.

[gone, 2012/09/15 01:01:55]

Done.

 
   static bool Register(JNIEnv* env);
 
  private:
-  void CreateJavaObject(JNIEnv* env);
-
   // NetworkChangeNotifier:

[szym, 2012/09/14 19:07:29]

since you're already here, make it "net::NetworkChangeNotifier:" unless you add
the "Android" suffix to the top-level class.

[gone, 2012/09/15 01:01:55]

Appended the Android suffix.

   virtual net::NetworkChangeNotifier::ConnectionType
       GetCurrentConnectionType() const OVERRIDE;