Add native-side unit test for Android NetworkChangeNotifier

net/android/network_change_notifier_android.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_ANDROID_NETWORK_CHANGE_NOTIFIER_ANDROID_H_
 #define NET_ANDROID_NETWORK_CHANGE_NOTIFIER_ANDROID_H_
 
 #include "base/android/scoped_java_ref.h"
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "net/base/network_change_notifier.h"
 
 namespace net {
 namespace android {
 
 class NetworkChangeNotifier : public net::NetworkChangeNotifier {

[szym, 2012/09/14 19:07:29]

Hmm, I'm not sure that using namespace android and overloading names like that
is best for readability. You are within namespace net so NetworkChangeNotifier
should be net::NetworkChangeNotifier. This should likely be
NetworkChangeNotifierAndroid to match Chromium naming style.

Perhaps another CL to avoid merge conflicts, and this applies to
net::android::NetworkChangeNotifierFactory too.

[gone, 2012/09/15 01:01:55]

Moved it over for this CL; it'll likely land after pliard's change.

  public:
   NetworkChangeNotifier();
   virtual ~NetworkChangeNotifier();
 
-  void NotifyObservers(JNIEnv* env, jobject obj);
+  void NotifyObserversOfConnectionTypeChange(JNIEnv* env, jobject obj);
+
+  void ForceConnectivityState(bool state);

[szym, 2012/09/14 19:07:29]

What is this for? If this is for tests only, at least add a comment, but
preferably hide it in the private section and friend the test suite.

[gone, 2012/09/15 01:01:55]

Done.

 
   static bool Register(JNIEnv* env);
 
  private:
-  void CreateJavaObject(JNIEnv* env);
-
   // NetworkChangeNotifier:

[szym, 2012/09/14 19:07:29]

since you're already here, make it "net::NetworkChangeNotifier:" unless you add
the "Android" suffix to the top-level class.

[gone, 2012/09/15 01:01:55]

Appended the Android suffix.

   virtual net::NetworkChangeNotifier::ConnectionType
       GetCurrentConnectionType() const OVERRIDE;
 
   base::android::ScopedJavaGlobalRef<jobject> java_network_change_notifier_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkChangeNotifier);
 };
 
 }  // namespace android
 }  // namespace net
 
 #endif  // NET_ANDROID_NETWORK_CHANGE_NOTIFIER_ANDROID_H_