Issue 10928039: Add support for testing Android's NTP w/o Android.

Issue 10928039: Add support for testing Android's NTP w/o Android. (Closed)

Created:
8 years, 3 months ago by Ted C

Modified:
8 years, 3 months ago

Reviewers:
Evan Stade, newt (away)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add support for testing Android's NTP w/o Android. Allows us to test html/js/css changes of the Android's NTP without needing to load it onto a device. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155920

Patch Set 1 #

Patch Set 2 : Fixed incorrect favicon function name #

Total comments: 6

Patch Set 3 : Resolved review nits. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1575 lines, -13 lines)			Patch
A	chrome/browser/resources/ntp_android/mockdata.js	View	1	1 chunk	+1571 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp_android/new_tab.html	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	chrome/browser/resources/ntp_android/ntp_android.js	View	1 2	4 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm with nit*3 http://codereview.chromium.org/10928039/diff/2001/chrome/browser/resources/ntp_android/ntp_android.js File chrome/browser/resources/ntp_android/ntp_android.js (right): http://codereview.chromium.org/10928039/diff/2001/chrome/browser/resources/ntp_android/ntp_android.js#newcode596 chrome/browser/resources/ntp_android/ntp_android.js:596: item.icon ? item.icon : 'chrome://touch-icon/size/64/' + ...

8 years, 3 months ago (2012-09-10 09:16:08 UTC) #2

Ted C

http://codereview.chromium.org/10928039/diff/2001/chrome/browser/resources/ntp_android/ntp_android.js File chrome/browser/resources/ntp_android/ntp_android.js (right): http://codereview.chromium.org/10928039/diff/2001/chrome/browser/resources/ntp_android/ntp_android.js#newcode596 chrome/browser/resources/ntp_android/ntp_android.js:596: item.icon ? item.icon : 'chrome://touch-icon/size/64/' + item.url; On 2012/09/10 ...

8 years, 3 months ago (2012-09-10 22:35:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10928039/6002

8 years, 3 months ago (2012-09-10 23:58:21 UTC) #4

Change committed as 155920

Expand Messages | Collapse Messages