Installer changes for app host to support command line install from webstore

Installer changes for app host to support command line install from webstore

This a companion to codereview.chromium.org/10907104/ (which added the 
support in chrome itself to do the install). 

TBR=sky@chromium.org (chrome/common/chrome_switches.{h,cc} changes)

BUG=138311
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157493

[erikwright (departed), 2012-09-18 00:57:37]

LGTM.

[asargent_no_longer_on_chrome, 2012-09-18 04:07:32]

+gab for chrome/installer/ files OWNERS review

[gab, 2012-09-18 16:44:21]

lgtm w/ one comment below.

http://codereview.chromium.org/10919321/diff/1/chrome/installer/setup/install...
File chrome/installer/setup/install_worker.cc (right):

http://codereview.chromium.org/10919321/diff/1/chrome/installer/setup/install...
chrome/installer/setup/install_worker.cc:191:
cmd_line.AppendSwitchASCII(::switches::kInstallFromWebstore, "%1");
According to the comments on those switches: kAppsInstallFromManifestURL took a
URL while kInstallFromWebstore takes an app ID... are app IDs URL? was this
previously broken? (i.e. when is this invoked and what is "%1"?).

[asargent_no_longer_on_chrome, 2012-09-18 16:59:14]

http://codereview.chromium.org/10919321/diff/1/chrome/installer/setup/install...
File chrome/installer/setup/install_worker.cc (right):

http://codereview.chromium.org/10919321/diff/1/chrome/installer/setup/install...
chrome/installer/setup/install_worker.cc:191:
cmd_line.AppendSwitchASCII(::switches::kInstallFromWebstore, "%1");
On 2012/09/18 16:44:21, gab wrote:
> According to the comments on those switches: kAppsInstallFromManifestURL took
a
> URL while kInstallFromWebstore takes an app ID... are app IDs URL? was this
> previously broken? (i.e. when is this invoked and what is "%1"?).

This code was written in advance of chrome actually supporting the
kAppsInstallFromManifestURL flag, so passing it was just a no-op.

I was tasked with actually implementing that functionality in chrome, but it
turned out to be easier to pass an app id than a URL to an app, because we
already had inline install code
(https://developers.google.com/chrome/web-store/docs/inline_installation) which
just needs the id. So the code we'll be using to call the installer will just
pass this id instead of a URL.

[commit-bot: I haz the power, 2012-09-18 17:00:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asargent@chromium.org/10919321/1

[commit-bot: I haz the power, 2012-09-18 18:18:49]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-09-18 23:36:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asargent@chromium.org/10919321/1

[commit-bot: I haz the power, 2012-09-19 04:08:00]

Change committed as 157493