Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1408)

Unified Diff: chrome/browser/extensions/api/usb/usb_api.cc

Issue 10919201: Make sure that a given app/extension requests only its own resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/usb/usb_api.cc
diff --git a/chrome/browser/extensions/api/usb/usb_api.cc b/chrome/browser/extensions/api/usb/usb_api.cc
index 71e4c32dcce2725722f3febefdef1736e4dc1368..548d17d37f417213743d3885d0286e1e5386fdb5 100644
--- a/chrome/browser/extensions/api/usb/usb_api.cc
+++ b/chrome/browser/extensions/api/usb/usb_api.cc
@@ -76,7 +76,8 @@ void UsbFindDeviceFunction::Work() {
return;
}
- UsbDeviceResource* const resource = new UsbDeviceResource(event_notifier_,
+ UsbDeviceResource* const resource = new UsbDeviceResource(extension_->id(),
+ event_notifier_,
device);
Device result;
@@ -101,11 +102,12 @@ bool UsbCloseDeviceFunction::Prepare() {
}
void UsbCloseDeviceFunction::Work() {
- UsbDeviceResource* const device = manager_->Get(parameters_->device.handle);
+ UsbDeviceResource* const device = manager_->Get(extension_->id(),
+ parameters_->device.handle);
if (device)
device->Close();
- manager_->Remove(parameters_->device.handle);
+ manager_->Remove(extension_->id(), parameters_->device.handle);
}
bool UsbCloseDeviceFunction::Respond() {
@@ -123,7 +125,8 @@ bool UsbControlTransferFunction::Prepare() {
}
void UsbControlTransferFunction::Work() {
- UsbDeviceResource* const device = manager_->Get(parameters_->device.handle);
+ UsbDeviceResource* const device = manager_->Get(extension_->id(),
+ parameters_->device.handle);
if (device) {
device->ControlTransfer(parameters_->transfer_info);
}
@@ -144,7 +147,8 @@ UsbBulkTransferFunction::UsbBulkTransferFunction() {}
UsbBulkTransferFunction::~UsbBulkTransferFunction() {}
void UsbBulkTransferFunction::Work() {
- UsbDeviceResource* const device = manager_->Get(parameters_->device.handle);
+ UsbDeviceResource* const device = manager_->Get(extension_->id(),
+ parameters_->device.handle);
if (device) {
device->BulkTransfer(parameters_->transfer_info);
}
@@ -165,7 +169,8 @@ bool UsbInterruptTransferFunction::Prepare() {
}
void UsbInterruptTransferFunction::Work() {
- UsbDeviceResource* const device = manager_->Get(parameters_->device.handle);
+ UsbDeviceResource* const device = manager_->Get(extension_->id(),
+ parameters_->device.handle);
if (device) {
device->InterruptTransfer(parameters_->transfer_info);
}
@@ -186,7 +191,8 @@ bool UsbIsochronousTransferFunction::Prepare() {
}
void UsbIsochronousTransferFunction::Work() {
- UsbDeviceResource* const device = manager_->Get(parameters_->device.handle);
+ UsbDeviceResource* const device = manager_->Get(extension_->id(),
+ parameters_->device.handle);
if (device) {
device->IsochronousTransfer(parameters_->transfer_info);
}

Powered by Google App Engine
This is Rietveld 408576698