chrome/browser/extensions/api/socket/tcp_socket_unittest.cc - Issue 10919201: Make sure that a given app/extension requests only its own resources.

Unified Diff: chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

Issue 10919201: Make sure that a given app/extension requests only its own resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/serial/serial_api.cc ('K') | « chrome/browser/extensions/api/socket/tcp_socket.cc ('k') | chrome/browser/extensions/api/socket/udp_socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

diff --git a/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc b/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

index 16ae87967d50ba59a2c58493410d0759be5257b4..1e58c5f561e2fc10df9b23cdcbe223b366df5797 100644

--- a/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

+++ b/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

@@ -73,7 +73,7 @@ TEST(SocketTest, TestTCPSocketRead) {

CompleteHandler handler;

scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(

- tcp_client_socket, notifier));

+ tcp_client_socket, "fake_id", notifier));

Mihai Parparita -not on Chrome 2012/09/11 07:18:19 Extension IDs are always 20 characters long, other

EXPECT_CALL(*tcp_client_socket, Read(_, _, _))

.Times(1);

@@ -92,7 +92,7 @@ TEST(SocketTest, TestTCPSocketWrite) {

CompleteHandler handler;

scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(

- tcp_client_socket, notifier));

+ tcp_client_socket, "fake_id", notifier));

net::CompletionCallback callback;

EXPECT_CALL(*tcp_client_socket, Write(_, _, _))

@@ -115,7 +115,7 @@ TEST(SocketTest, TestTCPSocketBlockedWrite) {

CompleteHandler handler;

scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(

- tcp_client_socket, notifier));

+ tcp_client_socket, "fake_id", notifier));

net::CompletionCallback callback;

EXPECT_CALL(*tcp_client_socket, Write(_, _, _))

@@ -141,7 +141,7 @@ TEST(SocketTest, TestTCPSocketBlockedWriteReentry) {

CompleteHandler handlers[5];

scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(

- tcp_client_socket, notifier));

+ tcp_client_socket, "fake_id", notifier));

net::CompletionCallback callback;

EXPECT_CALL(*tcp_client_socket, Write(_, _, _))

@@ -173,7 +173,7 @@ TEST(SocketTest, TestTCPSocketSetNoDelay) {

MockApiResourceEventNotifier* notifier = new MockApiResourceEventNotifier();

scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(

- tcp_client_socket, notifier));

+ tcp_client_socket, "fake_id", notifier));

bool no_delay = false;

EXPECT_CALL(*tcp_client_socket, SetNoDelay(_))

@@ -196,7 +196,7 @@ TEST(SocketTest, TestTCPSocketSetKeepAlive) {

MockApiResourceEventNotifier* notifier = new MockApiResourceEventNotifier();

scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(

- tcp_client_socket, notifier));

+ tcp_client_socket, "fake_id", notifier));

bool enable = false;

int delay = 0;