Make sure that a given app/extension requests only its own resources.

chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/socket/tcp_socket.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/extensions/api/api_resource_event_notifier.h"
 #include "net/base/address_list.h"
 #include "net/base/completion_callback.h"
@@ skipping 55 matching lines @@
 };
 
 
 TEST(SocketTest, TestTCPSocketRead) {
   net::AddressList address_list;
   MockTCPSocket* tcp_client_socket = new MockTCPSocket(address_list);
   ApiResourceEventNotifier* notifier = new MockApiResourceEventNotifier();
   CompleteHandler handler;
 
   scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(
-      tcp_client_socket, notifier));
+      tcp_client_socket, "fake_id", notifier));

[Mihai Parparita -not on Chrome, 2012/09/11 07:18:19]

Extension IDs are always 20 characters long, other tests generally conform to
that (e.g.
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/extensions/...)

 
   EXPECT_CALL(*tcp_client_socket, Read(_, _, _))
       .Times(1);
   EXPECT_CALL(handler, OnReadComplete(_, _))
       .Times(1);
 
   const int count = 512;
   socket->Read(count, base::Bind(&CompleteHandler::OnReadComplete,
         base::Unretained(&handler)));
 }
 
 TEST(SocketTest, TestTCPSocketWrite) {
   net::AddressList address_list;
   MockTCPSocket* tcp_client_socket = new MockTCPSocket(address_list);
   ApiResourceEventNotifier* notifier = new MockApiResourceEventNotifier();
   CompleteHandler handler;
 
   scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(
-      tcp_client_socket, notifier));
+      tcp_client_socket, "fake_id", notifier));
 
   net::CompletionCallback callback;
   EXPECT_CALL(*tcp_client_socket, Write(_, _, _))
       .Times(2)
       .WillRepeatedly(testing::DoAll(SaveArg<2>(&callback),
                                      Return(128)));
   EXPECT_CALL(handler, OnComplete(_))
       .Times(1);
 
   scoped_refptr<net::IOBufferWithSize> io_buffer(
       new net::IOBufferWithSize(256));
   socket->Write(io_buffer.get(), io_buffer->size(),
       base::Bind(&CompleteHandler::OnComplete, base::Unretained(&handler)));
 }
 
 TEST(SocketTest, TestTCPSocketBlockedWrite) {
   net::AddressList address_list;
   MockTCPSocket* tcp_client_socket = new MockTCPSocket(address_list);
   MockApiResourceEventNotifier* notifier = new MockApiResourceEventNotifier();
   CompleteHandler handler;
 
   scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(
-      tcp_client_socket, notifier));
+      tcp_client_socket, "fake_id", notifier));
 
   net::CompletionCallback callback;
   EXPECT_CALL(*tcp_client_socket, Write(_, _, _))
       .Times(2)
       .WillRepeatedly(testing::DoAll(SaveArg<2>(&callback),
                                      Return(net::ERR_IO_PENDING)));
   scoped_refptr<net::IOBufferWithSize> io_buffer(new net::IOBufferWithSize(42));
   socket->Write(io_buffer.get(), io_buffer->size(),
       base::Bind(&CompleteHandler::OnComplete, base::Unretained(&handler)));
 
   // Good. Original call came back unable to complete. Now pretend the socket
   // finished, and confirm that we passed the error back.
   EXPECT_CALL(handler, OnComplete(42))
       .Times(1);
   callback.Run(40);
   callback.Run(2);
 }
 
 TEST(SocketTest, TestTCPSocketBlockedWriteReentry) {
   net::AddressList address_list;
   MockTCPSocket* tcp_client_socket = new MockTCPSocket(address_list);
   MockApiResourceEventNotifier* notifier = new MockApiResourceEventNotifier();
   CompleteHandler handlers[5];
 
   scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(
-      tcp_client_socket, notifier));
+      tcp_client_socket, "fake_id", notifier));
 
   net::CompletionCallback callback;
   EXPECT_CALL(*tcp_client_socket, Write(_, _, _))
       .Times(5)
       .WillRepeatedly(testing::DoAll(SaveArg<2>(&callback),
                                      Return(net::ERR_IO_PENDING)));
   scoped_refptr<net::IOBufferWithSize> io_buffers[5];
   int i;
   for (i = 0; i < 5; i++) {
     io_buffers[i] = new net::IOBufferWithSize(128 + i * 50);
@@ skipping 11 matching lines @@
     callback.Run(128 + i * 50);
   }
 }
 
 TEST(SocketTest, TestTCPSocketSetNoDelay) {
   net::AddressList address_list;
   MockTCPSocket* tcp_client_socket = new MockTCPSocket(address_list);
   MockApiResourceEventNotifier* notifier = new MockApiResourceEventNotifier();
 
   scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(
-      tcp_client_socket, notifier));
+      tcp_client_socket, "fake_id", notifier));
 
   bool no_delay = false;
   EXPECT_CALL(*tcp_client_socket, SetNoDelay(_))
       .WillOnce(testing::DoAll(SaveArg<0>(&no_delay), Return(true)));
   int result = socket->SetNoDelay(true);
   EXPECT_TRUE(result);
   EXPECT_TRUE(no_delay);
 
   EXPECT_CALL(*tcp_client_socket, SetNoDelay(_))
       .WillOnce(testing::DoAll(SaveArg<0>(&no_delay), Return(false)));
 
   result = socket->SetNoDelay(false);
   EXPECT_FALSE(result);
   EXPECT_FALSE(no_delay);
 }
 
 TEST(SocketTest, TestTCPSocketSetKeepAlive) {
   net::AddressList address_list;
   MockTCPSocket* tcp_client_socket = new MockTCPSocket(address_list);
   MockApiResourceEventNotifier* notifier = new MockApiResourceEventNotifier();
 
   scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(
-      tcp_client_socket, notifier));
+      tcp_client_socket, "fake_id", notifier));
 
   bool enable = false;
   int delay = 0;
   EXPECT_CALL(*tcp_client_socket, SetKeepAlive(_, _))
       .WillOnce(testing::DoAll(SaveArg<0>(&enable),
                                SaveArg<1>(&delay),
                                Return(true)));
   int result = socket->SetKeepAlive(true, 4500);
   EXPECT_TRUE(result);
   EXPECT_TRUE(enable);
   EXPECT_EQ(4500, delay);
 
   EXPECT_CALL(*tcp_client_socket, SetKeepAlive(_, _))
       .WillOnce(testing::DoAll(SaveArg<0>(&enable),
                                SaveArg<1>(&delay),
                                Return(false)));
   result = socket->SetKeepAlive(false, 0);
   EXPECT_FALSE(result);
   EXPECT_FALSE(enable);
   EXPECT_EQ(0, delay);
 }
 
 }  // namespace extensions