Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 10919169: Change how PepperMessageFilter is constructed, to simplify its use. (Closed)

Created:
8 years, 3 months ago by bbudge
Modified:
8 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Change how PepperMessageFilter is constructed, to simplify its use. Changes the ctor's HostResolver parameter to render_process_id, and adds code to get the HostResolver. Modifies the single call site, and delegate objects that actually call the constructor. BUG=116317 TEST=existing, no new functionality.

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -49 lines) Patch
M content/browser/plugin_service_impl.h View 2 chunks +2 lines, -0 lines 1 comment Download
M content/browser/plugin_service_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_message_filter.h View 1 3 chunks +9 lines, -11 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_message_filter.cc View 1 9 chunks +31 lines, -23 lines 2 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bbudge
I think I was able to work around the PepperTCPSocket problem by passing the HostResolver ...
8 years, 3 months ago (2012-09-07 23:56:49 UTC) #1
brettw
8 years, 3 months ago (2012-09-10 22:27:11 UTC) #2
http://codereview.chromium.org/10919169/diff/9002/content/browser/plugin_serv...
File content/browser/plugin_service_impl.h (right):

http://codereview.chromium.org/10919169/diff/9002/content/browser/plugin_serv...
content/browser/plugin_service_impl.h:131: int render_process_id,
Can you add a comment about what this is?

http://codereview.chromium.org/10919169/diff/9002/content/browser/renderer_ho...
File content/browser/renderer_host/pepper/pepper_message_filter.cc (right):

http://codereview.chromium.org/10919169/diff/9002/content/browser/renderer_ho...
content/browser/renderer_host/pepper/pepper_message_filter.cc:91:
process_id_(render_process_id),
I'm not totally following this. In the case of Flash, there will be one Flash
process and one PpapiPluginProcessHost in the browser. There will be many
renderers talking to it. The reason this process ID was previously set to 0 is
that there is no "the renderer" that we're talking to, we're talking to many
renderers in the case where type == PLUGIN.

Do we need a new type or something?

Powered by Google App Engine
This is Rietveld 408576698