Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: src/trusted/service_runtime/arch/mips/sel_ldr_mips.h

Issue 10919162: [MIPS] Implementation of sel_ldr for MIPS architecture. (Closed) Base URL: http://src.chromium.org/native_client/trunk/src/native_client/
Patch Set: Second update per Mark's comments. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/service_runtime/arch/mips/sel_ldr_mips.h
diff --git a/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h b/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h
new file mode 100644
index 0000000000000000000000000000000000000000..e0e8807b1110037662e757e5bb77589a8c2ff691
--- /dev/null
+++ b/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h
@@ -0,0 +1,31 @@
+/*
+ * Copyright 2012 The Native Client Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can
+ * be found in the LICENSE file.
+ */
+
+#ifndef SERVICE_RUNTIME_ARCH_MIPS_SEL_LDR_H__
+#define SERVICE_RUNTIME_ARCH_MIPS_SEL_LDR_H__ 1
+
+#include "native_client/src/include/portability.h"
+#include "native_client/src/trusted/service_runtime/nacl_config.h"
+
+#define NACL_MAX_ADDR_BITS 30
+
+#define NACL_ADDRSPACE_LOWER_GUARD_SIZE 0
+#define NACL_ADDRSPACE_UPPER_GUARD_SIZE 0x2000
+
+/* Must be synced with irt_compatible_rodata_addr in SConstruct */
+#define NACL_DATA_SEGMENT_START 0x10000000
+
+#define NACL_THREAD_MAX 8192
+
+#define NACL_NOOP_OPCODE 0x00000000 /* nop */
+#define NACL_HALT_OPCODE 0x00000008 /* jr $0 */
Mark Seaborn 2012/09/18 03:24:34 I'm not sure if this was addressed by your design
petarj 2012/09/19 17:27:51 It gets executed, but the exception occurs right a
Mark Seaborn 2012/09/20 02:40:42 Did you consider using a breakpoint instruction?
petarj 2012/09/20 15:33:00 We hesitated previously to use break instruction,
+#define NACL_HALT_LEN 4 /* length of halt instruction */
+#define NACL_HALT_WORD NACL_HALT_OPCODE
+
+struct NaClApp;
Mark Seaborn 2012/09/18 03:24:34 Nit: you don't need these two forward declarations
petarj 2012/09/19 17:27:51 Done.
+struct NaClThreadContext;
+
+#endif /* SERVICE_RUNTIME_ARCH_MIPS_SEL_LDR_H__ */

Powered by Google App Engine
This is Rietveld 408576698