Provide mutable members of UrlRequestContext via pure-virtual interface

net/url_request/url_request_http_job.cc

Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 901e3e758104206d81d4087fff4470093156bd85..b475e6e461c8219898c4f2e0ca129988aeb917fc 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -466,15 +466,15 @@ void URLRequestHttpJob::AddExtraHeaders() {
   const URLRequestContext* context = request_->context();

[willchan no longer on Chromium, 2012/10/06 19:32:49]

Long-term, we should pass in the HttpUserAgentSettings here directly, rather
than going through the context, right Erik? I wonder if we should just do it
here right now.

[erikwright (departed), 2012/10/09 15:24:46]

Correct. I think it would make a good statement about the intended design if at
least this file used the new object exclusively.

   // Only add default Accept-Language and Accept-Charset if the request
   // didn't have them specified.
-  if (!context->accept_language().empty()) {
+  if (!context->GetAcceptLanguage().empty()) {

[mmenke, 2012/10/05 20:08:51]

Suggest you cache both of these to a local to avoid the double virtual call /
string copy.

     request_info_.extra_headers.SetHeaderIfMissing(
         HttpRequestHeaders::kAcceptLanguage,
-        context->accept_language());
+        context->GetAcceptLanguage());
   }
-  if (!context->accept_charset().empty()) {
+  if (!context->GetAcceptCharset().empty()) {
     request_info_.extra_headers.SetHeaderIfMissing(
         HttpRequestHeaders::kAcceptCharset,
-        context->accept_charset());
+        context->GetAcceptCharset());
   }
 }