Provide mutable members of UrlRequestContext via pure-virtual interface

net/url_request/url_request_http_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_http_job.h"
 
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
@@ skipping 445 matching lines @@
         // Since we're tagging this transaction as advertising a dictionary,
         // we'll definitely employ an SDCH filter (or tentative sdch filter)
         // when we get a response.  When done, we'll record histograms via
         // SDCH_DECODE or SDCH_PASSTHROUGH.  Hence we need to record packet
         // arrival times.
         packet_timing_enabled_ = true;
       }
     }
   }
 
   const URLRequestContext* context = request_->context();

[willchan no longer on Chromium, 2012/10/06 19:32:49]

Long-term, we should pass in the HttpUserAgentSettings here directly, rather
than going through the context, right Erik? I wonder if we should just do it
here right now.

[erikwright (departed), 2012/10/09 15:24:46]

Correct. I think it would make a good statement about the intended design if at
least this file used the new object exclusively.

   // Only add default Accept-Language and Accept-Charset if the request
   // didn't have them specified.
-  if (!context->accept_language().empty()) {
+  if (!context->GetAcceptLanguage().empty()) {

[mmenke, 2012/10/05 20:08:51]

Suggest you cache both of these to a local to avoid the double virtual call /
string copy.

     request_info_.extra_headers.SetHeaderIfMissing(
         HttpRequestHeaders::kAcceptLanguage,
-        context->accept_language());
+        context->GetAcceptLanguage());
   }
-  if (!context->accept_charset().empty()) {
+  if (!context->GetAcceptCharset().empty()) {
     request_info_.extra_headers.SetHeaderIfMissing(
         HttpRequestHeaders::kAcceptCharset,
-        context->accept_charset());
+        context->GetAcceptCharset());
   }
 }
 
 void URLRequestHttpJob::AddCookieHeaderAndStart() {
   // No matter what, we want to report our status as IO pending since we will
   // be notifying our consumer asynchronously via OnStartCompleted.
   SetStatus(URLRequestStatus(URLRequestStatus::IO_PENDING, 0));
 
   // If the request was destroyed, then there is no more work to do.
   if (!request_)
@@ skipping 1013 matching lines @@
 
 void URLRequestHttpJob::NotifyURLRequestDestroyed() {
   awaiting_callback_ = false;
 }
 
 void URLRequestHttpJob::OnDetachRequest() {
   http_transaction_delegate_->OnDetachRequest();
 }
 
 }  // namespace net