Provide mutable members of UrlRequestContext via pure-virtual interface

chrome/browser/automation/url_request_automation_job.cc

Index: chrome/browser/automation/url_request_automation_job.cc
diff --git a/chrome/browser/automation/url_request_automation_job.cc b/chrome/browser/automation/url_request_automation_job.cc
index a5c790d09072eae3091a6b509104ee23df2f0a93..7be9c34d57a44e14fc8538e913e4a313949377a8 100644
--- a/chrome/browser/automation/url_request_automation_job.cc
+++ b/chrome/browser/automation/url_request_automation_job.cc
@@ -423,15 +423,15 @@ void URLRequestAutomationJob::StartAsync() {
   // didn't have them specified.

[willchan no longer on Chromium, 2012/10/06 19:32:49]

Is this code simply redundant? Doesn't URLRequestHttpJob already do this via
SetHeaderIfMissing()? If I'm right, can we simply delete this code?

[mmenke, 2012/10/08 15:06:31]

That's done in URLRequestJob::Start (Which calls
URLRequestHttpJob::AddExtraHeaders).  Doesn't look to me like that's called for
AutomationJobs.

   if (!new_request_headers.HasHeader(
       net::HttpRequestHeaders::kAcceptLanguage) &&
-      !request_->context()->accept_language().empty()) {
+      !request_->context()->GetAcceptLanguage().empty()) {

[mmenke, 2012/10/05 20:08:51]

Suggest you avoid the double virtual call / string copy here and below by moving
it to a local.

     new_request_headers.SetHeader(net::HttpRequestHeaders::kAcceptLanguage,
-                                  request_->context()->accept_language());
+                                  request_->context()->GetAcceptLanguage());
   }
   if (!new_request_headers.HasHeader(
       net::HttpRequestHeaders::kAcceptCharset) &&
-      !request_->context()->accept_charset().empty()) {
+      !request_->context()->GetAcceptCharset().empty()) {
     new_request_headers.SetHeader(net::HttpRequestHeaders::kAcceptCharset,
-                                  request_->context()->accept_charset());
+                                  request_->context()->GetAcceptCharset());
   }
 
   // Ensure that we do not send username and password fields in the referrer.