Provide mutable members of UrlRequestContext via pure-virtual interface

chrome/browser/automation/url_request_automation_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/url_request_automation_job.h"
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
 #include "base/time.h"
@@ skipping 402 matching lines @@
   // Register this request with automation message filter.
   message_filter_->RegisterRequest(this);
 
   // Strip unwanted headers.
   net::HttpRequestHeaders new_request_headers;
   new_request_headers.MergeFrom(request_->extra_request_headers());
   for (size_t i = 0; i < arraysize(kFilteredHeaderStrings); ++i)
     new_request_headers.RemoveHeader(kFilteredHeaderStrings[i]);
 
   // Only add default Accept-Language and Accept-Charset if the request
   // didn't have them specified.

[willchan no longer on Chromium, 2012/10/06 19:32:49]

Is this code simply redundant? Doesn't URLRequestHttpJob already do this via
SetHeaderIfMissing()? If I'm right, can we simply delete this code?

[mmenke, 2012/10/08 15:06:31]

That's done in URLRequestJob::Start (Which calls
URLRequestHttpJob::AddExtraHeaders).  Doesn't look to me like that's called for
AutomationJobs.

   if (!new_request_headers.HasHeader(
       net::HttpRequestHeaders::kAcceptLanguage) &&
-      !request_->context()->accept_language().empty()) {
+      !request_->context()->GetAcceptLanguage().empty()) {

[mmenke, 2012/10/05 20:08:51]

Suggest you avoid the double virtual call / string copy here and below by moving
it to a local.

     new_request_headers.SetHeader(net::HttpRequestHeaders::kAcceptLanguage,
-                                  request_->context()->accept_language());
+                                  request_->context()->GetAcceptLanguage());
   }
   if (!new_request_headers.HasHeader(
       net::HttpRequestHeaders::kAcceptCharset) &&
-      !request_->context()->accept_charset().empty()) {
+      !request_->context()->GetAcceptCharset().empty()) {
     new_request_headers.SetHeader(net::HttpRequestHeaders::kAcceptCharset,
-                                  request_->context()->accept_charset());
+                                  request_->context()->GetAcceptCharset());
   }
 
   // Ensure that we do not send username and password fields in the referrer.
   GURL referrer(request_->GetSanitizedReferrer());
 
   // The referrer header must be suppressed if the preceding URL was
   // a secure one and the new one is not.
   if (referrer.SchemeIsSecure() && !request_->url().SchemeIsSecure()) {
     DVLOG(1) << "Suppressing referrer header since going from secure to "
                 "non-secure";
@@ skipping 43 matching lines @@
   if (!is_done()) {
     NotifyDone(request_status_);
   }
   // Reset any pending reads.
   if (pending_buf_) {
     pending_buf_ = NULL;
     pending_buf_size_ = 0;
     NotifyReadComplete(0);
   }
 }