Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 10918166: Wrap string literals for FilePath with FILE_PATH_LITERAL macro (Closed)

Created:
8 years, 3 months ago by nhiroki
Modified:
8 years, 3 months ago
Reviewers:
kochi
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, kinuko
Visibility:
Public.

Description

Passing string literals to FilePath constructor causes type conversion errors on Windows trybot. Those literals should be wrapped with FILE_PATH_LITERAL macro. BUG=127855 TEST=pass all existing tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/chromeos/gdata/operation_registry_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nhiroki
Hi, kochi-san Can you review this? Thanks!
8 years, 3 months ago (2012-09-11 07:58:12 UTC) #1
kochi
lgtm I'm concerned about other usages in chromeos/gdata directory. As they were not compiled for ...
8 years, 3 months ago (2012-09-11 08:20:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/10918166/1
8 years, 3 months ago (2012-09-11 08:30:42 UTC) #3
nhiroki
On 2012/09/11 08:20:28, Takayoshi Kochi wrote: > lgtm > > I'm concerned about other usages ...
8 years, 3 months ago (2012-09-11 08:33:03 UTC) #4
nhiroki
On 2012/09/11 08:33:03, nhiroki wrote: > On 2012/09/11 08:20:28, Takayoshi Kochi wrote: > > lgtm ...
8 years, 3 months ago (2012-09-11 11:14:53 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-11 11:30:04 UTC) #6
Change committed as 155985

Powered by Google App Engine
This is Rietveld 408576698