Rename elements of LinkType enum

Rename elements of the LinkType enum to "kSomething" to avoid naming conflict.
Specifically "ALTERNATE" caused a conflict problem on Windows build.

BUG=146809
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155376

[nhiroki, 2012-09-07 00:10:33]

Hi, kochi-san

Could you review this? Thanks!

[kochi, 2012-09-07 01:15:24]

LGTM

Please write in description that specifically "ALTERNATE"
caused a conflict problem on Windows build.

[commit-bot: I haz the power, 2012-09-07 01:33:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/10918101/1

[commit-bot: I haz the power, 2012-09-07 13:05:22]

Change committed as 155376

[satorux1, 2012-09-07 17:08:50]

http://codereview.chromium.org/10918101/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_wapi_parser.h (right):

http://codereview.chromium.org/10918101/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_wapi_parser.h:72: kOpenWith,
This is not allowed. Filed a bug:
http://code.google.com/p/chromium/issues/detail?id=147284

http://www.chromium.org/developers/coding-style

Though the Google C++ Style Guide says to use kConstantNaming for enums, Chrome
still uses MACRO_STYLE naming for enums for consistency with our existing code.

[kinuko, 2012-09-09 12:41:16]

On 2012/09/07 17:08:50, satorux1 wrote:
>
http://codereview.chromium.org/10918101/diff/1/chrome/browser/chromeos/gdata/...
> File chrome/browser/chromeos/gdata/gdata_wapi_parser.h (right):
> 
>
http://codereview.chromium.org/10918101/diff/1/chrome/browser/chromeos/gdata/...
> chrome/browser/chromeos/gdata/gdata_wapi_parser.h:72: kOpenWith,
> This is not allowed. Filed a bug:
> http://code.google.com/p/chromium/issues/detail?id=147284
> 
> http://www.chromium.org/developers/coding-style
> 
> Though the Google C++ Style Guide says to use kConstantNaming for enums,
Chrome
> still uses MACRO_STYLE naming for enums for consistency with our existing
code.

If we're in doubt we should ask this on chromium-dev, but I don't think this
phrase is particularly saying 'kConstantNaming' naming is NOT allowed in enums.

I briefly remember I heard we use BOTH, and actually we could see a lot of
kCamelCase type enums broadly used in the chromium code base, even in base/ or
in net/.

[satorux1, 2012-09-09 15:41:07]

On 2012/09/09 12:41:16, kinuko wrote:
> On 2012/09/07 17:08:50, satorux1 wrote:
> >
>
http://codereview.chromium.org/10918101/diff/1/chrome/browser/chromeos/gdata/...
> > File chrome/browser/chromeos/gdata/gdata_wapi_parser.h (right):
> > 
> >
>
http://codereview.chromium.org/10918101/diff/1/chrome/browser/chromeos/gdata/...
> > chrome/browser/chromeos/gdata/gdata_wapi_parser.h:72: kOpenWith,
> > This is not allowed. Filed a bug:
> > http://code.google.com/p/chromium/issues/detail?id=147284
> > 
> > http://www.chromium.org/developers/coding-style
> > 
> > Though the Google C++ Style Guide says to use kConstantNaming for enums,
> Chrome
> > still uses MACRO_STYLE naming for enums for consistency with our existing
> code.
> 
> If we're in doubt we should ask this on chromium-dev, but I don't think this
> phrase is particularly saying 'kConstantNaming' naming is NOT allowed in
enums.
> 
> I briefly remember I heard we use BOTH, and actually we could see a lot of
> kCamelCase type enums broadly used in the chromium code base, even in base/ or
> in net/.

Other enums in the same directory are named LIKE_THIS so please be consistent
with others.