Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 10917062: Add bookmark entry point histogram for bookmark prompt experiment (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix build break Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/bookmarks/bookmark_utils.h ('K') | « chrome/browser/bookmarks/bookmark_utils.h ('k') | chrome/browser/ui/views/location_bar/star_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 7fb2ea9701ee6b0c4c180dc2654e25bf85b52ec8..7120f764b1c732eeb7338e9136aa932b30981a8d 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -2399,6 +2399,11 @@ void BrowserView::UpdateAcceleratorMetrics(
if (command_id == IDC_HELP_PAGE_VIA_KEYBOARD && key_code == ui::VKEY_F1)
content::RecordAction(UserMetricsAction("ShowHelpTabViaF1"));
+ if (command_id == IDC_BOOKMARK_PAGE)
+ UMA_HISTOGRAM_ENUMERATION("Bookmarks.EntryPoint",
+ bookmark_utils::ENTRY_POINT_ACCELERATOR,
+ bookmark_utils::ENTRY_POINT_LIMIT);
+
#if defined(OS_CHROMEOS)
// Collect information about the relative popularity of various accelerators
// on Chrome OS.
« chrome/browser/bookmarks/bookmark_utils.h ('K') | « chrome/browser/bookmarks/bookmark_utils.h ('k') | chrome/browser/ui/views/location_bar/star_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698