chrome/browser/bookmarks/bookmark_utils.cc - Issue 10917062: Add bookmark entry point histogram for bookmark prompt experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_utils.cc

Issue 10917062: Add bookmark entry point histogram for bookmark prompt experiment (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update chrome/tools/chromeactions.txt for BookmarkAdded Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/bookmarks/bookmark_utils.cc

diff --git a/chrome/browser/bookmarks/bookmark_utils.cc b/chrome/browser/bookmarks/bookmark_utils.cc

index b972189d231f304d657468ef09e22553458ad23f..0fc8515a00b6be762b6b3e4cd7f68facef6e998a 100644

--- a/chrome/browser/bookmarks/bookmark_utils.cc

+++ b/chrome/browser/bookmarks/bookmark_utils.cc

@@ -25,6 +25,7 @@

#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/browser/ui/simple_message_box.h"

#include "chrome/common/pref_names.h"

+#include "content/public/browser/user_metrics.h"

#include "content/public/browser/web_contents.h"

#include "grit/chromium_strings.h"

#include "grit/generated_resources.h"

@@ -689,6 +690,7 @@ void AddIfNotBookmarked(BookmarkModel* model,

if (!bookmarks.empty())

return; // Nothing to do, a bookmark with that url already exists.

+ content::RecordAction(content::UserMetricsAction("BookmarkAdded"));

const BookmarkNode* parent = model->GetParentForNewNodes();

model->AddURL(parent, parent->child_count(), title, url);

}