Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: chrome/browser/bookmarks/bookmark_utils.cc

Issue 10917062: Add bookmark entry point histogram for bookmark prompt experiment (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update chrome/tools/chromeactions.txt for BookmarkAdded Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/bookmark_utils.h" 5 #include "chrome/browser/bookmarks/bookmark_utils.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/file_path.h" 10 #include "base/file_path.h"
11 #include "base/i18n/case_conversion.h" 11 #include "base/i18n/case_conversion.h"
12 #include "base/i18n/string_search.h" 12 #include "base/i18n/string_search.h"
13 #include "base/metrics/histogram.h" 13 #include "base/metrics/histogram.h"
14 #include "base/string16.h" 14 #include "base/string16.h"
15 #include "base/string_number_conversions.h" 15 #include "base/string_number_conversions.h"
16 #include "base/time.h" 16 #include "base/time.h"
17 #include "base/utf_string_conversions.h" 17 #include "base/utf_string_conversions.h"
18 #include "chrome/browser/bookmarks/bookmark_model.h" 18 #include "chrome/browser/bookmarks/bookmark_model.h"
19 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 19 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
20 #include "chrome/browser/bookmarks/bookmark_node_data.h" 20 #include "chrome/browser/bookmarks/bookmark_node_data.h"
21 #include "chrome/browser/history/query_parser.h" 21 #include "chrome/browser/history/query_parser.h"
22 #include "chrome/browser/prefs/pref_service.h" 22 #include "chrome/browser/prefs/pref_service.h"
23 #include "chrome/browser/profiles/profile.h" 23 #include "chrome/browser/profiles/profile.h"
24 #include "chrome/browser/ui/browser.h" 24 #include "chrome/browser/ui/browser.h"
25 #include "chrome/browser/ui/browser_tabstrip.h" 25 #include "chrome/browser/ui/browser_tabstrip.h"
26 #include "chrome/browser/ui/simple_message_box.h" 26 #include "chrome/browser/ui/simple_message_box.h"
27 #include "chrome/common/pref_names.h" 27 #include "chrome/common/pref_names.h"
28 #include "content/public/browser/user_metrics.h"
28 #include "content/public/browser/web_contents.h" 29 #include "content/public/browser/web_contents.h"
29 #include "grit/chromium_strings.h" 30 #include "grit/chromium_strings.h"
30 #include "grit/generated_resources.h" 31 #include "grit/generated_resources.h"
31 #include "grit/ui_strings.h" 32 #include "grit/ui_strings.h"
32 #include "net/base/net_util.h" 33 #include "net/base/net_util.h"
33 #include "ui/base/dragdrop/drag_drop_types.h" 34 #include "ui/base/dragdrop/drag_drop_types.h"
34 #include "ui/base/l10n/l10n_util.h" 35 #include "ui/base/l10n/l10n_util.h"
35 #include "ui/base/models/tree_node_iterator.h" 36 #include "ui/base/models/tree_node_iterator.h"
36 37
37 #if defined(OS_MACOSX) 38 #if defined(OS_MACOSX)
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
682 } 683 }
683 684
684 void AddIfNotBookmarked(BookmarkModel* model, 685 void AddIfNotBookmarked(BookmarkModel* model,
685 const GURL& url, 686 const GURL& url,
686 const string16& title) { 687 const string16& title) {
687 std::vector<const BookmarkNode*> bookmarks; 688 std::vector<const BookmarkNode*> bookmarks;
688 model->GetNodesByURL(url, &bookmarks); 689 model->GetNodesByURL(url, &bookmarks);
689 if (!bookmarks.empty()) 690 if (!bookmarks.empty())
690 return; // Nothing to do, a bookmark with that url already exists. 691 return; // Nothing to do, a bookmark with that url already exists.
691 692
693 content::RecordAction(content::UserMetricsAction("BookmarkAdded"));
692 const BookmarkNode* parent = model->GetParentForNewNodes(); 694 const BookmarkNode* parent = model->GetParentForNewNodes();
693 model->AddURL(parent, parent->child_count(), title, url); 695 model->AddURL(parent, parent->child_count(), title, url);
694 } 696 }
695 697
696 void RemoveAllBookmarks(BookmarkModel* model, const GURL& url) { 698 void RemoveAllBookmarks(BookmarkModel* model, const GURL& url) {
697 std::vector<const BookmarkNode*> bookmarks; 699 std::vector<const BookmarkNode*> bookmarks;
698 model->GetNodesByURL(url, &bookmarks); 700 model->GetNodesByURL(url, &bookmarks);
699 701
700 // Remove all the bookmarks. 702 // Remove all the bookmarks.
701 for (size_t i = 0; i < bookmarks.size(); ++i) { 703 for (size_t i = 0; i < bookmarks.size(); ++i) {
(...skipping 17 matching lines...) Expand all
719 void DisableBookmarkBarViewAnimationsForTesting(bool disabled) { 721 void DisableBookmarkBarViewAnimationsForTesting(bool disabled) {
720 g_bookmark_bar_view_animations_disabled = disabled; 722 g_bookmark_bar_view_animations_disabled = disabled;
721 } 723 }
722 724
723 bool IsBookmarkBarViewAnimationsDisabled() { 725 bool IsBookmarkBarViewAnimationsDisabled() {
724 return g_bookmark_bar_view_animations_disabled; 726 return g_bookmark_bar_view_animations_disabled;
725 } 727 }
726 #endif 728 #endif
727 729
728 } // namespace bookmark_utils 730 } // namespace bookmark_utils
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698