Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 10916272: Remove HttpAuth::Scheme enum in favor of a string. (Closed)

Created:
8 years, 3 months ago by cbentzel
Modified:
7 years, 1 month ago
Reviewers:
asanka, eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove HttpAuth::Scheme enum in favor of a string. The existing HttpAuthHandlerRegistryFactory already allows for new HTTP Authentication schemes to be added to Chrome's networking stack, but an enum value needed to be change for each new one. By using string's instead of the enum, this is no longer a problem. It does sacrifice some potential compile-time safety checks, and arguably some performance although I am not worried about that here.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -154 lines) Patch
M net/http/http_auth.h View 4 chunks +2 lines, -14 lines 0 comments Download
M net/http/http_auth.cc View 4 chunks +4 lines, -23 lines 0 comments Download
M net/http/http_auth_cache.h View 6 chunks +6 lines, -6 lines 0 comments Download
M net/http/http_auth_cache.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M net/http/http_auth_cache_unittest.cc View 24 chunks +47 lines, -47 lines 0 comments Download
M net/http/http_auth_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_auth_controller.cc View 4 chunks +14 lines, -7 lines 0 comments Download
M net/http/http_auth_controller_unittest.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M net/http/http_auth_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_auth_handler.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/http/http_auth_handler_basic.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_digest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_factory_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_auth_handler_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_negotiate.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_ntlm.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_unittest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_spdy2_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket_pool_spdy3_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket_stream/socket_stream.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_spdy2_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_proxy_client_socket_spdy3_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
cbentzel
This is a sketch - still needs some work. I am simply soliciting opinions for ...
8 years, 3 months ago (2012-09-12 21:17:11 UTC) #1
asanka
On 2012/09/12 21:17:11, cbentzel wrote: > This is a sketch - still needs some work. ...
8 years, 3 months ago (2012-09-12 23:31:32 UTC) #2
eroman
7 years, 6 months ago (2013-06-04 20:50:10 UTC) #3
Can this issue be closed? (shows up in my incoming queue)

Powered by Google App Engine
This is Rietveld 408576698