Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 10916056: Setup network JNI for webkit_unit_tests. (Closed)

Created:
8 years, 3 months ago by Philippe
Modified:
8 years, 3 months ago
Reviewers:
tkent, Xianzhu
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Setup network JNI for webkit_unit_tests. JNI was intentionally not setup for webkit_unit_tests since we were not building an APK for testing not so long ago. We can now setup JNI. This will fix tests like AssociatedURLLoaderTest.SameOriginSuccess that were failing internally after I tried to eliminate some unnecessary diffs we have in net/ (e.g.: see 0f9f6577da12fa112442a4f5aff17e171db5e96f internally). TEST=webkit_unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157922

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M webkit/support/platform_support_android.cc View 1 2 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Philippe
8 years, 3 months ago (2012-09-21 00:21:10 UTC) #1
Xianzhu
lgtm
8 years, 3 months ago (2012-09-21 00:26:29 UTC) #2
tkent
LGTM
8 years, 3 months ago (2012-09-21 00:49:01 UTC) #3
Philippe
Thanks guys.
8 years, 3 months ago (2012-09-21 00:52:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10916056/7001
8 years, 3 months ago (2012-09-21 00:53:52 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 03:54:49 UTC) #6
Change committed as 157922

Powered by Google App Engine
This is Rietveld 408576698