Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 10915293: Simplify tracing of gpu memory (Closed)

Created:
8 years, 3 months ago by nduca
Modified:
8 years, 3 months ago
Reviewers:
piman, ccameron
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Simplify tracing of gpu memory BUG=128502 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157071

Patch Set 1 #

Patch Set 2 : even less stuff #

Patch Set 3 : even less #

Patch Set 4 : Reestore transfer buffer magic #

Total comments: 1

Patch Set 5 : nitfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -49 lines) Patch
M content/common/gpu/gpu_memory_manager.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.cc View 1 chunk +1 line, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 11 chunks +2 lines, -18 lines 0 comments Download
M gpu/command_buffer/service/memory_tracking.h View 1 2 3 4 3 chunks +1 line, -14 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.cc View 1 chunk +1 line, -4 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 chunk +1 line, -4 lines 0 comments Download
M gpu/command_buffer/service/transfer_buffer_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
nduca
8 years, 3 months ago (2012-09-15 00:08:12 UTC) #1
ccameron
On 2012/09/15 00:08:12, nduca wrote: LGTM. I haven't had use for the extra information yet, ...
8 years, 3 months ago (2012-09-15 00:13:24 UTC) #2
ccameron
The transfer_buffer_manager.cc stuff isn't GPU memory, and isn't tracked anywhere else AFAIK, so I'd prefer ...
8 years, 3 months ago (2012-09-15 00:26:46 UTC) #3
nduca
Fair enough. Will undo that bit.
8 years, 3 months ago (2012-09-15 00:29:41 UTC) #4
ccameron
On 2012/09/15 00:29:41, nduca wrote: > Fair enough. Will undo that bit. LGTM doit.
8 years, 3 months ago (2012-09-15 00:40:26 UTC) #5
piman
lgtm http://codereview.chromium.org/10915293/diff/10002/gpu/command_buffer/service/memory_tracking.h File gpu/command_buffer/service/memory_tracking.h (right): http://codereview.chromium.org/10915293/diff/10002/gpu/command_buffer/service/memory_tracking.h#newcode36 gpu/command_buffer/service/memory_tracking.h:36: MemoryTracker* memory_tracker) nit: fit on previous line?
8 years, 3 months ago (2012-09-15 01:14:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/10915293/8
8 years, 3 months ago (2012-09-15 01:16:24 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-15 03:04:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/10915293/8
8 years, 3 months ago (2012-09-17 01:36:07 UTC) #9
commit-bot: I haz the power
8 years, 3 months ago (2012-09-17 03:16:30 UTC) #10
Change committed as 157071

Powered by Google App Engine
This is Rietveld 408576698