Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10915226: OBSOLETE - Move drive.proto to browser/google_apis directory (Closed)

Created:
8 years, 3 months ago by nhiroki
Modified:
8 years, 3 months ago
Reviewers:
satorux1, kochi
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, kinuko
Visibility:
Public.

Description

OBSOLETE - We quit moving whole drive.proto. Please see comments on http://codereview.chromium.org/10920091/ Move drive.proto to browser/google_apis directory BUG=127855

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -187 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/document_entry_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/document_entry_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/gdata/drive.proto View 1 chunk +0 lines, -148 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_cache_metadata.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_cache_metadata_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_download_observer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_file_system.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_file_system_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_file_system_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_file_system_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_files.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_files.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_function_remove.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_protocol_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_resource_metadata.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_resource_metadata_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_sync_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_sync_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_task_executor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_wapi_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/stale_cache_files_remover.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/stale_cache_files_remover_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
A + chrome/browser/google_apis/drive.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nhiroki
Could you review this? Thanks
8 years, 3 months ago (2012-09-12 10:21:28 UTC) #1
nhiroki
8 years, 3 months ago (2012-09-13 07:49:20 UTC) #2 
I quit moving whole drive.proto.
Please see comments on http://codereview.chromium.org/10920091/

Thanks

Powered by Google App Engine
This is Rietveld 408576698