Browser test for the push messaging feature

chrome/browser/sync/profile_sync_service.h

Index: chrome/browser/sync/profile_sync_service.h
diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h
index 216ef1c483e0c9627677b173784f642894c14ad1..68fa0f4f6b80e9f89c3cd3f84130b9abf61482c1 100644
--- a/chrome/browser/sync/profile_sync_service.h
+++ b/chrome/browser/sync/profile_sync_service.h
@@ -575,6 +575,11 @@ class ProfileSyncService : public browser_sync::SyncFrontend,
   // ProfileKeyedService implementation.
   virtual void Shutdown() OVERRIDE;
 
+  // test method for system test to allow a test to send in an invalidation

[dcheng, 2012/09/13 21:00:48]

I think you could simplify this comment to "Method to trigger an invalidation in
tests."

[Pete Williamson, 2012/09/14 19:14:48]

Done.

+  virtual void SendNotificationForTest(

[dcheng, 2012/09/13 21:00:48]

Suggestion: this should be called SendInvalidationForTest().

[dcheng, 2012/09/13 21:00:48]

Doesn't need to be virtual. It's possible that this method should be added to
InvalidationFrontend as a virtual method though, and then overridden here.

[Pete Williamson, 2012/09/14 19:14:48]

Done.

[Pete Williamson, 2012/09/14 19:14:48]

Made non virtual, but I didn't want to extend the encapsulation break any
further than I needed to.

+      const std::string& id,
+      const std::string& payload);
+
  protected:
   // Used by test classes that derive from ProfileSyncService.
   virtual browser_sync::SyncBackendHost* GetBackendForTest();