Browser test for the push messaging feature

chrome/browser/sync/profile_sync_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 
 #include <list>
 #include <string>
 
@@ skipping 557 matching lines @@
   virtual void UpdateRegisteredInvalidationIds(
       syncer::InvalidationHandler* handler,
       const syncer::ObjectIdSet& ids) OVERRIDE;
   virtual void UnregisterInvalidationHandler(
       syncer::InvalidationHandler* handler) OVERRIDE;
   virtual syncer::InvalidatorState GetInvalidatorState() const OVERRIDE;
 
   // ProfileKeyedService implementation.
   virtual void Shutdown() OVERRIDE;
 
+  // test method for system test to allow a test to send in an invalidation

[dcheng, 2012/09/13 21:00:48]

I think you could simplify this comment to "Method to trigger an invalidation in
tests."

[Pete Williamson, 2012/09/14 19:14:48]

Done.

+  virtual void SendNotificationForTest(

[dcheng, 2012/09/13 21:00:48]

Suggestion: this should be called SendInvalidationForTest().

[dcheng, 2012/09/13 21:00:48]

Doesn't need to be virtual. It's possible that this method should be added to
InvalidationFrontend as a virtual method though, and then overridden here.

[Pete Williamson, 2012/09/14 19:14:48]

Done.

[Pete Williamson, 2012/09/14 19:14:48]

Made non virtual, but I didn't want to extend the encapsulation break any
further than I needed to.

+      const std::string& id,
+      const std::string& payload);
+
  protected:
   // Used by test classes that derive from ProfileSyncService.
   virtual browser_sync::SyncBackendHost* GetBackendForTest();
 
   // Helper to install and configure a data type manager.
   void ConfigureDataTypeManager();
 
   // Starts up the backend sync components.
   void StartUp();
   // Shuts down the backend sync components.
@@ skipping 262 matching lines @@
   syncer::InvalidatorRegistrar invalidator_registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
 };
 
 bool ShouldShowActionOnUI(
     const syncer::SyncProtocolError& error);
 
 
 #endif  // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_