Issue 10915214: ash: Update system update notification behaviour.

Issue 10915214: ash: Update system update notification behaviour. (Closed)

Created:
8 years, 3 months ago by sadrul

Modified:
8 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Update system update notification behaviour. Decorate the update notification appropriately depending on the severity of the update recommendation. BUG=145577 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156263

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : win-fix #

Total comments: 2

Patch Set 4 : . #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -15 lines)			Patch
M	ash/system/tray/tray_image_item.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/system/tray/tray_image_item.cc	View	1 2 3	1 chunk	+8 lines, -0 lines	0 comments	Download
M	ash/system/tray_update.h	View		3 chunks	+4 lines, -8 lines	0 comments	Download
M	ash/system/tray_update.cc	View	1 2 3	5 chunks	+31 lines, -5 lines	0 comments	Download
M	ash/system/user/update_observer.h	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/system/ash_system_tray_delegate.cc	View	1	1 chunk	+23 lines, -1 line	0 comments	Download
M	chrome/browser/upgrade_detector.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/10915214/diff/8001/ash/system/tray/tray_image_item.h File ash/system/tray/tray_image_item.h (right): http://codereview.chromium.org/10915214/diff/8001/ash/system/tray/tray_image_item.h#newcode26 ash/system/tray/tray_image_item.h:26: void UpdateResourceId(int resource_id); Add a description. Also, while ...

8 years, 3 months ago (2012-09-11 23:07:14 UTC) #2

sadrul

http://codereview.chromium.org/10915214/diff/8001/ash/system/tray/tray_image_item.h File ash/system/tray/tray_image_item.h (right): http://codereview.chromium.org/10915214/diff/8001/ash/system/tray/tray_image_item.h#newcode26 ash/system/tray/tray_image_item.h:26: void UpdateResourceId(int resource_id); On 2012/09/11 23:07:14, sky wrote: > ...

8 years, 3 months ago (2012-09-12 09:00:41 UTC) #3

LGTM

Expand Messages | Collapse Messages