Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10915202: Cleanup: merge MockQuotaManager in multiple places (Closed)

Created:
8 years, 3 months ago by kinuko
Modified:
8 years, 3 months ago
Reviewers:
michaeln, Mike West, tzik
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Merge MockQuotaManager in multiple places - to share the single implementation in existing tests - to make it easier for writing new tests BUG=none TEST=existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157964

Patch Set 1 : #

Total comments: 1

Patch Set 2 : rebased #

Patch Set 3 : rebase2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -236 lines) Patch
M webkit/appcache/appcache_storage_unittest.cc View 2 chunks +28 lines, -60 lines 0 comments Download
M webkit/fileapi/local_file_system_operation_unittest.cc View 1 2 16 chunks +36 lines, -140 lines 0 comments Download
M webkit/quota/mock_quota_manager.h View 2 chunks +132 lines, -36 lines 0 comments Download
M webkit/quota/mock_quota_manager.cc View 3 chunks +71 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
Not a high priority one... nor reducing much line. PTL when you have time thanks.
8 years, 3 months ago (2012-09-12 05:54:21 UTC) #1
tzik
LGTM http://codereview.chromium.org/10915202/diff/1001/webkit/fileapi/local_file_system_operation_unittest.cc File webkit/fileapi/local_file_system_operation_unittest.cc (right): http://codereview.chromium.org/10915202/diff/1001/webkit/fileapi/local_file_system_operation_unittest.cc#newcode26 webkit/fileapi/local_file_system_operation_unittest.cc:26: #include "webkit/quota/mock_quota_manager.h" sort?
8 years, 3 months ago (2012-09-12 07:25:39 UTC) #2
Mike West
LGTM, and the bot failures look like flake. Thanks Kinuko!
8 years, 3 months ago (2012-09-12 14:21:07 UTC) #3
kinuko
thanks! will wait for michael's review for the change in appcache/.
8 years, 3 months ago (2012-09-13 05:47:41 UTC) #4
michaeln
LGTM2
8 years, 3 months ago (2012-09-13 20:50:58 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 10:57:10 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698