chrome/browser/ui/extensions/shell_window.h - Issue 10915047: Links in platform apps should open in the system default browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/shell_window.h

Issue 10915047: Links in platform apps should open in the system default browser. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: refine the patch according to Mihaip's comment. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/platform_app_browsertest_util.h ('K') | « chrome/browser/extensions/platform_app_browsertest_util.cc ('k') | chrome/browser/ui/extensions/shell_window.cc » ('j') | chrome/browser/ui/extensions/shell_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/shell_window.h

diff --git a/chrome/browser/ui/extensions/shell_window.h b/chrome/browser/ui/extensions/shell_window.h

index 88bcfe11613fd6094d7ffa3e9b282241f467c45f..fe1ca68fd6769f7b74244fdecdea3c0225f8d636 100644

--- a/chrome/browser/ui/extensions/shell_window.h

+++ b/chrome/browser/ui/extensions/shell_window.h

@@ -97,6 +97,10 @@ class ShellWindow : public content::NotificationObserver,

// Save the window position in the prefs.

virtual void SaveWindowPosition();

+ // Set the WebContentsDelegate for external url in test.

+ static void SetExternalUrlControllerForTesting(

+ content::WebContentsDelegate* controller);

protected:

ShellWindow(Profile* profile,

const extensions::Extension* extension);