chrome/browser/extensions/platform_app_browsertest_util.cc - Issue 10915047: Links in platform apps should open in the system default browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/platform_app_browsertest_util.cc

Issue 10915047: Links in platform apps should open in the system default browser. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: refine the patch according to Mihaip's comment. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/platform_app_browsertest_util.h ('K') | « chrome/browser/extensions/platform_app_browsertest_util.h ('k') | chrome/browser/ui/extensions/shell_window.h » ('j') | chrome/browser/ui/extensions/shell_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/platform_app_browsertest_util.cc

diff --git a/chrome/browser/extensions/platform_app_browsertest_util.cc b/chrome/browser/extensions/platform_app_browsertest_util.cc

index a722eb590f43465756c4dcc0d13fa7a596aad27a..fbfee5ef08c81de6c6451fc814a1ee713ea9f122 100644

--- a/chrome/browser/extensions/platform_app_browsertest_util.cc

+++ b/chrome/browser/extensions/platform_app_browsertest_util.cc

@@ -27,6 +27,12 @@ void PlatformAppBrowserTest::SetUpCommandLine(CommandLine* command_line) {

command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis);

}

+void PlatformAppBrowserTest::SetUpOnMainThread() {

+ mock_external_url_controller_.reset(new MockExternalUrlController());

+ ShellWindow::SetExternalUrlControllerForTesting(

+ mock_external_url_controller_.get());

const Extension* PlatformAppBrowserTest::LoadAndLaunchPlatformApp(

const char* name) {

content::WindowedNotificationObserver app_loaded_observer(