BrowsingDataRemover: Work around HistoryService not handling delete_end as expected.

chrome/browser/browsing_data/browsing_data_remover.cc

Index: chrome/browser/browsing_data/browsing_data_remover.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc
index 58cbe5c231600ea3ceda5a9b290ca10ca6249791..b8e687b2325b13d522eee0574fb71eee75d4551d 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover.cc
@@ -242,8 +242,12 @@ void BrowsingDataRemover::RemoveImpl(int remove_mask,
         restrict_urls.insert(remove_origin_);
       content::RecordAction(UserMetricsAction("ClearBrowsingData_History"));
       waiting_for_clear_history_ = true;
+      // The history service doesn't correctly handle delete_end_. Work around
+      // it by always passing a NULL time here (it will delete everything until
+      // delete_begin_). TODO(sky, rohitrao): Remove this workaround when the

[sky, 2012/08/31 15:50:06]

This worries me in so far as you're assuming delete_end_ is always going to be
nowish. If that's the case, can we explicitly remove delete_end_ to make that
clear?

[rohitrao (ping after 24h), 2012/08/31 15:53:35]

Per an earlier comment, the Extensions API allows extensions to clear arbitrary
time ranges, so this will break for any extension that does so.  That seems bad.

Is there any way to test for a "nowish" Time?

+      // bug is fixed.
       history_service->ExpireHistoryBetween(restrict_urls,
-          delete_begin_, delete_end_,
+          delete_begin_, base::Time(),
           &request_consumer_,
           base::Bind(&BrowsingDataRemover::OnHistoryDeletionDone,
                      base::Unretained(this)));