BrowsingDataRemover: Work around HistoryService not handling delete_end as expected.

chrome/browser/browsing_data/browsing_data_remover.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/browsing_data_remover.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 224 matching lines @@
 
   if (remove_mask & REMOVE_HISTORY) {
     HistoryService* history_service = HistoryServiceFactory::GetForProfile(
         profile_, Profile::EXPLICIT_ACCESS);
     if (history_service) {
       std::set<GURL> restrict_urls;
       if (!remove_origin_.is_empty())
         restrict_urls.insert(remove_origin_);
       content::RecordAction(UserMetricsAction("ClearBrowsingData_History"));
       waiting_for_clear_history_ = true;
+      // The history service doesn't correctly handle delete_end_. Work around
+      // it by always passing a NULL time here (it will delete everything until
+      // delete_begin_). TODO(sky, rohitrao): Remove this workaround when the

[sky, 2012/08/31 15:50:06]

This worries me in so far as you're assuming delete_end_ is always going to be
nowish. If that's the case, can we explicitly remove delete_end_ to make that
clear?

[rohitrao (ping after 24h), 2012/08/31 15:53:35]

Per an earlier comment, the Extensions API allows extensions to clear arbitrary
time ranges, so this will break for any extension that does so.  That seems bad.

Is there any way to test for a "nowish" Time?

+      // bug is fixed.
       history_service->ExpireHistoryBetween(restrict_urls,
-          delete_begin_, delete_end_,
+          delete_begin_, base::Time(),
           &request_consumer_,
           base::Bind(&BrowsingDataRemover::OnHistoryDeletionDone,
                      base::Unretained(this)));
     }
 
     // Need to clear the host cache and accumulated speculative data, as it also
     // reveals some history: we have no mechanism to track when these items were
     // created, so we'll clear them all. Better safe than sorry.
     if (g_browser_process->io_thread()) {
       waiting_for_clear_networking_history_ = true;
@@ skipping 669 matching lines @@
       BrowserThread::UI, FROM_HERE,
       base::Bind(&BrowsingDataRemover::OnClearedFormData,
                  base::Unretained(this)));
 }
 
 void BrowsingDataRemover::OnClearedFormData() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   waiting_for_clear_form_ = false;
   NotifyAndDeleteIfDone();
 }