BrowsingDataRemover: Work around HistoryService not handling delete_end as expected.

chrome/browser/browsing_data/browsing_data_remover.cc

Index: chrome/browser/browsing_data/browsing_data_remover.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc
index 58cbe5c231600ea3ceda5a9b290ca10ca6249791..1fc2b920379089d65972243bb8cf27be0162b136 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover.cc
@@ -242,8 +242,11 @@ void BrowsingDataRemover::RemoveImpl(int remove_mask,
         restrict_urls.insert(remove_origin_);
       content::RecordAction(UserMetricsAction("ClearBrowsingData_History"));
       waiting_for_clear_history_ = true;
+      // The history service doesn't correctly handle delete_end_. Work around
+      // it by always passing a NULL time here (it will delete everything until
+      // delete_begin_).
       history_service->ExpireHistoryBetween(restrict_urls,
-          delete_begin_, delete_end_,
+          delete_begin_, base::Time(),

[rohitrao (ping after 24h), 2012/08/30 15:25:16]

This hack only works if callers always pass Time::Now() for delete_end_.  Is
that assumption true?  Does anyone ever create a BrowsingDataRemover object for
an arbitrary time range in the past?

Explicitly checking for Time::Max() would remove this assumption, but then this
CL would be blocked on changing all callers to pass Time::Max() instead of
Time::Now().

[marja, 2012/08/30 15:28:44]

Via the extension API it's possible to invoke BrowsingDataRemover with arbitrary
delete_end_s. So this hack will break them. But if the history service is not
anyway obeying delete_end_...

Yep, Time::Max() is not yet in use, and to make this patch mergeable to earlier
branches, we can't rely on it.

           &request_consumer_,
           base::Bind(&BrowsingDataRemover::OnHistoryDeletionDone,
                      base::Unretained(this)));