BrowsingDataRemover: Work around HistoryService not handling delete_end as expected.

chrome/browser/browsing_data/browsing_data_remover.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/browsing_data_remover.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 224 matching lines @@
 
   if (remove_mask & REMOVE_HISTORY) {
     HistoryService* history_service = HistoryServiceFactory::GetForProfile(
         profile_, Profile::EXPLICIT_ACCESS);
     if (history_service) {
       std::set<GURL> restrict_urls;
       if (!remove_origin_.is_empty())
         restrict_urls.insert(remove_origin_);
       content::RecordAction(UserMetricsAction("ClearBrowsingData_History"));
       waiting_for_clear_history_ = true;
+      // The history service doesn't correctly handle delete_end_. Work around
+      // it by always passing a NULL time here (it will delete everything until
+      // delete_begin_).
       history_service->ExpireHistoryBetween(restrict_urls,
-          delete_begin_, delete_end_,
+          delete_begin_, base::Time(),

[rohitrao (ping after 24h), 2012/08/30 15:25:16]

This hack only works if callers always pass Time::Now() for delete_end_.  Is
that assumption true?  Does anyone ever create a BrowsingDataRemover object for
an arbitrary time range in the past?

Explicitly checking for Time::Max() would remove this assumption, but then this
CL would be blocked on changing all callers to pass Time::Max() instead of
Time::Now().

[marja, 2012/08/30 15:28:44]

Via the extension API it's possible to invoke BrowsingDataRemover with arbitrary
delete_end_s. So this hack will break them. But if the history service is not
anyway obeying delete_end_...

Yep, Time::Max() is not yet in use, and to make this patch mergeable to earlier
branches, we can't rely on it.

           &request_consumer_,
           base::Bind(&BrowsingDataRemover::OnHistoryDeletionDone,
                      base::Unretained(this)));
     }
 
     // Need to clear the host cache and accumulated speculative data, as it also
     // reveals some history: we have no mechanism to track when these items were
     // created, so we'll clear them all. Better safe than sorry.
     if (g_browser_process->io_thread()) {
       waiting_for_clear_networking_history_ = true;
@@ skipping 669 matching lines @@
       BrowserThread::UI, FROM_HERE,
       base::Bind(&BrowsingDataRemover::OnClearedFormData,
                  base::Unretained(this)));
 }
 
 void BrowsingDataRemover::OnClearedFormData() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   waiting_for_clear_form_ = false;
   NotifyAndDeleteIfDone();
 }