Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 10914309: drive: Include base/logging.h explicitly in gdata_wapi_parser_unittest.cc (Closed)

Created:
8 years, 3 months ago by nhiroki
Modified:
8 years, 3 months ago
Reviewers:
satorux1
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Include base/logging.h explicitly for NOTREACHED macro Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/chromeos/gdata/gdata_wapi_parser_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nhiroki
Could you review this? Thanks
8 years, 3 months ago (2012-09-16 16:26:07 UTC) #1
satorux1
lgtm
8 years, 3 months ago (2012-09-17 02:22:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/10914309/1
8 years, 3 months ago (2012-09-17 02:22:46 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-17 04:38:01 UTC) #4
Change committed as 157077

Powered by Google App Engine
This is Rietveld 408576698