Improve panel tests by properly waiting for expected conditions.

chrome/browser/ui/panels/panel_gtk.cc

Index: chrome/browser/ui/panels/panel_gtk.cc
diff --git a/chrome/browser/ui/panels/panel_gtk.cc b/chrome/browser/ui/panels/panel_gtk.cc
index b7455e4e507799d2eb6677772cbc865f19586d6d..e8da2c2962c0bc62ab4e8934e2b966ebb2131b5d 100644
--- a/chrome/browser/ui/panels/panel_gtk.cc
+++ b/chrome/browser/ui/panels/panel_gtk.cc
@@ -947,6 +947,11 @@ gfx::Size PanelGtk::ContentSizeFromWindowSize(
 }
 
 int PanelGtk::TitleOnlyHeight() const {
+  gfx::Size& frame_size = GetFrameSize();
+  if (!frame_size.IsEmpty())
+    return frame_size.height() - kFrameBorderThickness;
+
+  LOG(WARNING) << "Checking title height before window allocated";

[jennb, 2012/09/13 00:45:34]

I intentionally left this log msg in to see if this ever gets called before
window is allocated. Will help track AutoResize() failure if it still flakes.

[Dmitry Titov, 2012/09/13 18:19:00]

Could you please move this note into a comment for this LOG? It'd be easier to
figure out why it is here later.

   GtkAllocation allocation;

[Dmitry Titov, 2012/09/13 18:19:00]

Do we actually need this code? It seems it should not be used in normal
conditions, right? Why not just NOTREACHED("Checking title height before window
was allocated")?

[jennb, 2012/09/13 18:40:48]

Changed to NOTREACHED using the log msg.

   gtk_widget_get_allocation(titlebar_->widget(), &allocation);
   return allocation.height;