Improve panel tests by properly waiting for expected conditions.

chrome/browser/ui/panels/panel_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_gtk.h"
 
 #include <gdk/gdk.h>
 #include <gdk/gdkkeysyms.h>
 #include <X11/XF86keysym.h>
 
@@ skipping 929 matching lines @@
 }
 
 gfx::Size PanelGtk::ContentSizeFromWindowSize(
     const gfx::Size& window_size) const {
   gfx::Size& frame_size = GetFrameSize();
   return gfx::Size(window_size.width() - frame_size.width(),
                    window_size.height() - frame_size.height());
 }
 
 int PanelGtk::TitleOnlyHeight() const {
+  gfx::Size& frame_size = GetFrameSize();
+  if (!frame_size.IsEmpty())
+    return frame_size.height() - kFrameBorderThickness;
+
+  LOG(WARNING) << "Checking title height before window allocated";

[jennb, 2012/09/13 00:45:34]

I intentionally left this log msg in to see if this ever gets called before
window is allocated. Will help track AutoResize() failure if it still flakes.

[Dmitry Titov, 2012/09/13 18:19:00]

Could you please move this note into a comment for this LOG? It'd be easier to
figure out why it is here later.

   GtkAllocation allocation;

[Dmitry Titov, 2012/09/13 18:19:00]

Do we actually need this code? It seems it should not be used in normal
conditions, right? Why not just NOTREACHED("Checking title height before window
was allocated")?

[jennb, 2012/09/13 18:40:48]

Changed to NOTREACHED using the log msg.

   gtk_widget_get_allocation(titlebar_->widget(), &allocation);
   return allocation.height;
 }
 
 void PanelGtk::SetPanelAlwaysOnTop(bool on_top) {
   gtk_window_set_keep_above(window_, on_top);
 
   // Do not show an icon in the task bar for always-on-top windows.
   // Window operations such as close, minimize etc. can only be done
   // from the panel UI.
@@ skipping 153 matching lines @@
       break;
     case panel::RESTORE_BUTTON:
       button = titlebar->restore_button();
       break;
     default:
       NOTREACHED();
       return false;
   }
   return gtk_widget_get_visible(button->widget());
 }